From: Julia Lawall <julia.lawall@inria.fr>
To: Aliya Rahmani <aliyarahmani786@gmail.com>
Cc: tomm.merciai@gmail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('
Date: Wed, 13 Apr 2022 12:26:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2204131226160.3091@hadrien> (raw)
In-Reply-To: <20220413101114.23992-1-aliyarahmani786@gmail.com>
On Wed, 13 Apr 2022, Aliya Rahmani wrote:
> Remove indentation to fix the checkpatch error that lines should not
> end with a '('.
This comment doesn't completely describe what was done.
julia
>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> ---
>
> v1->v2: Add Indentation and remove the gap between static and void.
>
> ---
> drivers/staging/vt6655/rxtx.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 53506e242a96..01dc83b2f4bc 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -567,19 +567,16 @@ s_uFillDataHead(
> return buf->duration;
> }
>
> -static
> -void
> -s_vFillRTSHead(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - void *pvRTS,
> - unsigned int cbFrameLength,
> - bool bNeedAck,
> - bool bDisCRC,
> - struct ieee80211_hdr *hdr,
> - unsigned short wCurrentRate,
> - unsigned char byFBOption
> -)
> +static void
> +s_vFillRTSHead(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + void *pvRTS,
> + unsigned int cbFrameLength,
> + bool bNeedAck,
> + bool bDisCRC,
> + struct ieee80211_hdr *hdr,
> + unsigned short wCurrentRate,
> + unsigned char byFBOption)
> {
> unsigned int uRTSFrameLen = 20;
>
> --
> 2.25.1
>
>
>
prev parent reply other threads:[~2022-04-13 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 10:11 [PATCH v2] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '(' Aliya Rahmani
2022-04-13 10:26 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2204131226160.3091@hadrien \
--to=julia.lawall@inria.fr \
--cc=aliyarahmani786@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox