From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 710767B; Sat, 11 Mar 2023 10:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=7KNwoXgjRer5LKYzZD+EoOuJEliyMODElb5INc7gnKU=; b=dECo1LXl3XnDhsJ0hMJoaeu5Sz4QvB7AR2k2FQ/nPXzkKNU7sHQwEfBp y5zFd2rozPyg15HLCMsC3p1NZ+qcijF1U/Ujqo7xuNBObeZUufguemQds s1AZ89y/6QRajgik8I4etGB7TIkIN58JcJh3E11KINhdY+gfo116/J0R0 M=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.98,252,1673910000"; d="scan'208";a="49873560" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2023 11:06:34 +0100 Date: Sat, 11 Mar 2023 11:06:33 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Khadija Kamran cc: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: axis-fifo: remove tabs to align arguments In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 11 Mar 2023, Khadija Kamran wrote: > In file drivers/staging/axis-fifo/axis-fifo.c, in line 386 and 529, last last -> the last > argument is indented as it were an argument of the second argument. as it -> as if it > Remove tabs to align the arguments. > > Signed-off-by: Khadija Kamran > --- > Changes in v2: > - Do not change the alignment of second argument > - Align arguments so last argument do not look like an argument of the > second argument. > - Fixed two instances of the same problem > > drivers/staging/axis-fifo/axis-fifo.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index dfd2b357f484..fbb3ff59dc7c 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -384,9 +384,9 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf, > mutex_lock(&fifo->read_lock); > ret = wait_event_interruptible_timeout(fifo->read_queue, > ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > - (read_timeout >= 0) ? > - msecs_to_jiffies(read_timeout) : > - MAX_SCHEDULE_TIMEOUT); > + (read_timeout >= 0) ? > + msecs_to_jiffies(read_timeout) : > + MAX_SCHEDULE_TIMEOUT); > > if (ret <= 0) { > if (ret == 0) { > @@ -527,10 +527,10 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf, > mutex_lock(&fifo->write_lock); > ret = wait_event_interruptible_timeout(fifo->write_queue, > ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) > - >= words_to_write, There is no need to change the above line. Maybe one could argue that it should be on the line before, but it is not part of the last argument of wait_event_interruptible_timeout, so it should not be changed in this patch. julia > - (write_timeout >= 0) ? > - msecs_to_jiffies(write_timeout) : > - MAX_SCHEDULE_TIMEOUT); > + >= words_to_write, > + (write_timeout >= 0) ? > + msecs_to_jiffies(write_timeout) : > + MAX_SCHEDULE_TIMEOUT); > > if (ret <= 0) { > if (ret == 0) { > -- > 2.34.1 > > >