From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5787B; Sat, 11 Mar 2023 12:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=b03HwkZ2a14zZdvvpOUvIPLLqWM5o2fF6Q3gk4QF67E=; b=LvsWNL8+mYwmo77wwIfzoxbddMcnYN4LdHna9xQ/3E7Y/i/fJbzQ3W1Q AqI9hCxh1qf5kdPbgNHxb3hVIBpn0gn4p2AujPO4YAeWdiSsXnfFiZiSt cZGUSoHJnncIYOXQc2CZVVUunZajr8nyNmPFn86/bE4NdC4mCCcwfTL4d g=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.98,252,1673910000"; d="scan'208";a="96640212" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2023 13:15:00 +0100 Date: Sat, 11 Mar 2023 13:15:00 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Khadija Kamran cc: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: axis-fifo: remove tabs to align arguments In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 11 Mar 2023, Khadija Kamran wrote: > In file drivers/staging/axis-fifo/axis-fifo.c, in line 386 and 529, the > last argument is indented as if it were an argument of the second > argument. Remove tabs to align the arguments. You don't need the file name or the line numbers. That information is sufficiently obvious in the patch itself. On the other hand, it could be helpful rto point out that these are calls to wait_event_interruptible_timeout and indeed that it is the timeout argument that is misplaced. That would help the reader know what to look for in reading the patch. julia > > Signed-off-by: Khadija Kamran > --- > Changes in v3: > - Do not align the line 530 since it is not part of the last argument. You can keep the entire history here. julia > drivers/staging/axis-fifo/axis-fifo.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index dfd2b357f484..b119cec25a60 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -384,9 +384,9 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf, > mutex_lock(&fifo->read_lock); > ret = wait_event_interruptible_timeout(fifo->read_queue, > ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > - (read_timeout >= 0) ? > - msecs_to_jiffies(read_timeout) : > - MAX_SCHEDULE_TIMEOUT); > + (read_timeout >= 0) ? > + msecs_to_jiffies(read_timeout) : > + MAX_SCHEDULE_TIMEOUT); > > if (ret <= 0) { > if (ret == 0) { > @@ -528,9 +528,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf, > ret = wait_event_interruptible_timeout(fifo->write_queue, > ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) > >= words_to_write, > - (write_timeout >= 0) ? > - msecs_to_jiffies(write_timeout) : > - MAX_SCHEDULE_TIMEOUT); > + (write_timeout >= 0) ? > + msecs_to_jiffies(write_timeout) : > + MAX_SCHEDULE_TIMEOUT); > > if (ret <= 0) { > if (ret == 0) { > -- > 2.34.1 > > >