From: Julia Lawall <julia.lawall@inria.fr>
To: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>,
outreachy@lists.linux.dev, pure.logic@nexus-software.ie,
johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: eclose macro in a do - while loop
Date: Sat, 11 Mar 2023 16:00:59 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2303111600330.2802@hadrien> (raw)
In-Reply-To: <c9ae27dc-3538-5432-6a6d-3e2ff034f467@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Sat, 11 Mar 2023, Menna Mahmoud wrote:
>
> On ١١/٣/٢٠٢٣ ١٦:٠٦, Dan Carpenter wrote:
> > On Sat, Mar 11, 2023 at 03:59:19PM +0200, Menna Mahmoud wrote:
> > > " ERROR: Macros with multiple statements should be enclosed in a do -
> > > while loop"
> > >
> > > Reported by checkpath.
> > >
> > > do loop with the conditional expression set to a constant
> > > value of zero (0).This creates a loop that
> > > will execute exactly one time.This is a coding idiom that
> > > allows a multi-line macro to be used anywhere
> > > that a single statement can be used.
> > >
> > > So, enclose `gb_loopback_stats_attrs` macro in do - while (0) to
> > > fix checkpath error
> > >
> > > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> > > ---
> > This breaks the build. You need to compile the code before sending a
> > patch.
> >
> > regards,
> > dan carpenter
>
>
> I see, I thought building the file only enough. appreciate your feedback.
The outreachy tutorial explains how to compile everything in a
subdirectory.
julia
next prev parent reply other threads:[~2023-03-11 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 13:59 [PATCH] staging: greybus: eclose macro in a do - while loop Menna Mahmoud
2023-03-11 14:06 ` Dan Carpenter
2023-03-11 14:51 ` Menna Mahmoud
2023-03-11 15:00 ` Julia Lawall [this message]
2023-03-12 13:39 ` Menna Mahmoud
2023-03-11 14:36 ` Julia Lawall
2023-03-11 14:54 ` Menna Mahmoud
2023-03-11 15:55 ` kernel test robot
2023-03-11 19:10 ` Alex Elder
2023-03-12 13:43 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2303111600330.2802@hadrien \
--to=julia.lawall@inria.fr \
--cc=elder@kernel.org \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox