From: Julia Lawall <julia.lawall@inria.fr>
To: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
johan@kernel.org, elder@kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: use inline function for macros
Date: Mon, 20 Mar 2023 07:00:48 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2303200659280.2940@hadrien> (raw)
In-Reply-To: <8e9724a0-226d-eb81-69c3-d59889e37e1f@gmail.com>
> > > and version that I have submitted, should I do anything about it as you
> > > said
> > > it is wrong solution?
> > My concern was the blank line after each of the structure definitions,
> > which is not in Greg's tree, so he can't apply the patch. Other than
> > that, if the code compiles it is at least going in the right direction.
> >
> > Please fix the newlines issue, and then send the patch again.
> >
> > julia
>
>
> Okay I will fix it, but will send it as a new patch not v3, right?
Why as a new patch? The change is the same as in v2, and sending v3 makes
it clear that v2 should be ignored.
julia
next prev parent reply other threads:[~2023-03-20 6:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 20:13 [PATCH] staging: greybus: use inline function for macros Menna Mahmoud
2023-03-19 20:21 ` Julia Lawall
2023-03-19 20:42 ` Menna Mahmoud
2023-03-19 20:55 ` Julia Lawall
2023-03-19 21:07 ` Menna Mahmoud
2023-03-19 21:26 ` Julia Lawall
2023-03-19 22:00 ` Menna Mahmoud
2023-03-19 22:06 ` Julia Lawall
2023-03-19 22:17 ` Menna Mahmoud
2023-03-20 6:00 ` Julia Lawall [this message]
2023-03-20 10:14 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2303200659280.2940@hadrien \
--to=julia.lawall@inria.fr \
--cc=elder@kernel.org \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox