From: Julia Lawall <julia.lawall@inria.fr>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, pure.logic@nexus-software.ie,
johan@kernel.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: greybus: Add blank line after struct declaration
Date: Sun, 10 Mar 2024 12:41:01 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2403101240300.3156@hadrien> (raw)
In-Reply-To: <20240310104714.22224-1-dorine.a.tipo@gmail.com>
On Sun, 10 Mar 2024, Dorine Tipo wrote:
> Add a blank line after the loopback_class struct declaration to improve
> code readability and adherence to coding style guidelines
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
Acked-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> Changes in v2:
> - Make the commit message clearer
>
> drivers/staging/greybus/loopback.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index bb33379b5297..4313d3bbc23a 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -101,6 +101,7 @@ struct gb_loopback {
> static struct class loopback_class = {
> .name = "gb_loopback",
> };
> +
> static DEFINE_IDA(loopback_ida);
>
> /* Min/max values in jiffies */
> --
> 2.25.1
>
>
>
next prev parent reply other threads:[~2024-03-10 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 5:37 [PATCH] staging: greybus: Add blank line after struct declaration Dorine Tipo
2024-03-10 10:47 ` [PATCH v2] " Dorine Tipo
2024-03-10 11:41 ` Julia Lawall [this message]
2024-03-11 23:04 ` [PATCH] " Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2403101240300.3156@hadrien \
--to=julia.lawall@inria.fr \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox