From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CBB954F83; Mon, 11 Mar 2024 20:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710190012; cv=none; b=iLAJVC1hiDQbRnxrD8b+aS5kpEoyUPhDmu9gnizVGOqVxVpNSvdk/3/JFcybUix5c2aQKp4PLpMYmCxS5p3lN2Qe+ZpmHqeyB1XJQM+Re7c04BYcYvSXzALHnF2skJBs/I8NW7NO03z0Ccv3HKxCSWBxcA00pU4sRJD2BLnaWJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710190012; c=relaxed/simple; bh=GL8gtGxJFo4rRuGjv65ntVbUl3g/4tkAZDn4iD3WG+g=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=GqZzN0zsfWfeahfELft1Rb/QK9vw7IwZFhvPoKfynbAXC8Pb6B1nJ+dztzb5oNm2Z/H9LiDZtRwBlgx/W12yM3WfioXD7KRuJRoXGAIcSr0Pz0v0nn5KTqJVWIR5hasl2B9WeVCdIaZAo0Y1o9k9XNnaFguixfpzLkTljtosLRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=kn7LzldE; arc=none smtp.client-ip=192.134.164.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="kn7LzldE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=UxyrIsgqNyhoQiWr/nMWx3jRYkmIAK+lVYg1CgDwTXM=; b=kn7LzldE/uGw6D5aRqFQgu9J6KyWDUYUfiZUEbfhvym3wZVpa11CWDaL arj4iqlpT6h81UPWe9v89hafcBzQx9cNGXfLa/bo5ogumIMibJFATLwEJ HrwhKlYnugMd2AmcLpEcfqH4ApL2N6A5jpNo7L1PJ5Ax1CQ12ERABzBPt w=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.07,117,1708383600"; d="scan'208";a="81848605" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 21:46:39 +0100 Date: Mon, 11 Mar 2024 21:46:38 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Philipp Hortmann cc: "Felix N. Kimbu" , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station In-Reply-To: <5f6b7fad-5ad3-44a0-9e10-3e1c13109abd@gmail.com> Message-ID: References: <4936c555-2c53-d421-126c-48804a26887d@inria.fr> <5f6b7fad-5ad3-44a0-9e10-3e1c13109abd@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 11 Mar 2024, Philipp Hortmann wrote: > On 3/11/24 18:05, Julia Lawall wrote: > > > > > > On Mon, 11 Mar 2024, Felix N. Kimbu wrote: > > > > > Remove unnecessary parentheses around 'wlandev->msdstate != > > > WLAN_MSD_RUNNING' > > > in static int prism2_get_station(...) > > > > You don't need the name of the function in the subject line. That > > information doesn't help understand the patch. > > > > julia > > Hi Julia, > > I think we do not need the function name in the subject but we need something > to distinguish between the patches. The subject line needs to be a little > unique. Otherwise we will have 100 patches like "[PATCH] staging: cfg80211: > Remove parentheses" when we are unlucky. Any better proposal for a Subject > uniqueness is welcome. > > Function name for this purpose is OK for me. OK, no problem. thanks, julia > > Thanks for your support. > > Bye Philipp > > > > > > > > > > This change ensures adherence to coding style guidelines. > > > > > > Signed-off-by: Felix N. Kimbu > > > --- > > > drivers/staging/wlan-ng/cfg80211.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/wlan-ng/cfg80211.c > > > b/drivers/staging/wlan-ng/cfg80211.c > > > index 471bb310176f..7451fd2bb580 100644 > > > --- a/drivers/staging/wlan-ng/cfg80211.c > > > +++ b/drivers/staging/wlan-ng/cfg80211.c > > > @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, > > > struct net_device *dev, > > > > > > memset(sinfo, 0, sizeof(*sinfo)); > > > > > > - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING)) > > > + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING) > > > return -EOPNOTSUPP; > > > > > > /* build request message */ > > > -- > > > 2.34.1 > > > > > > > > > > > > >