From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A696820CCDA; Sat, 22 Mar 2025 14:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742652668; cv=none; b=Px2/YFKxlhibXsLczwo+xLL7PQtixQJJNQbejG6fFgarzIJL3Bn4U1hZg6zZFx6L2nf71gW4nasKPbs1wf9mYjmR26TaaxlozZ1vDEtF18QZTk4LYyGQBWL1jbqQ4yQXDKsmRzFjH5MaaE6xhZMpx0sY9N24wnqNN6uVEKZoviY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742652668; c=relaxed/simple; bh=G1Z9UFHRMq3775bfxwMasta+Xz+dr7DnPOeYXAzGB4E=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Obb/AtDN56aKLQPjHGJD2DNZHRXpv8rPUNccg8FeNTdrQaQINbgFQYXpCxAG7q8sOlwwULjwJv9Dh1oorZQbt5Y6QSEZ3ELGLfbbqLdvqkZWRVAenFq2pPztU4d/OxaCevaiGCo6ODDybJaAxasybu6RBwwCX3Zx4BtH6+muNq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=QA9FhXh+; arc=none smtp.client-ip=192.134.164.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="QA9FhXh+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=dkqU/DbfmSzz4wjuxvy8BHU2ws4WmJo5/bVGqxFBkWc=; b=QA9FhXh+69sshlWIlRHeUVbEk7T0c7a28McpAUlLRqquQGzo4SHVV3lg JByHBJNngUfwkuroGY8OX1XqW+IdKGFGIGXErEAanSUXzGzrlA0h2hMrz nSUZX9kR9rp3N454+400/wjH/04eHDObWSUMv9fmjz5gzm4NFpfDHeLWW E=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.14,267,1736809200"; d="scan'208";a="112317675" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2025 15:11:03 +0100 Date: Sat, 22 Mar 2025 15:11:02 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Abraham Samuel Adekunle cc: outreachy@lists.linux.dev, julia.lawall@inria.fr, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: bcm2835-camera: Modify function call formatting In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 22 Mar 2025, Abraham Samuel Adekunle wrote: > The line is a function call which ends with an opening parenthesis > thereby not adhering to the Linux kernel coding style. > > Modify the function call to include parameters on the same line as > the opening parenthesis to improve readability and consistency while > adhering to Linux coding styles. > > Reported by checkpatch: > > CHECK: Lines should not end with '(' Please check the get_maintainer script (see tutorial). It looks like there are some other people who should receive patches on this driver. julia > > Signed-off-by: Abraham Samuel Adekunle > --- > .../vc04_services/bcm2835-camera/controls.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c > index 6bce45925bf1..e670226f1edf 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c > @@ -533,17 +533,15 @@ static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev, > > control = &dev->component[COMP_CAMERA]->control; > > - ret = vchiq_mmal_port_parameter_set( > - dev->instance, control, > - MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS, > - &imagefx, sizeof(imagefx)); > + ret = vchiq_mmal_port_parameter_set(dev->instance, control, > + MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS, > + &imagefx, sizeof(imagefx)); > if (ret) > goto exit; > > - ret = vchiq_mmal_port_parameter_set( > - dev->instance, control, > - MMAL_PARAMETER_COLOUR_EFFECT, > - &dev->colourfx, sizeof(dev->colourfx)); > + ret = vchiq_mmal_port_parameter_set(dev->instance, control, > + MMAL_PARAMETER_COLOUR_EFFECT, > + &dev->colourfx, sizeof(dev->colourfx)); > } > > exit: > -- > 2.34.1 > >