Re: [PATCH] staging: bcm2835-camera: Modify function call formatting

[Julia Lawall <julia.lawall@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]



On Sat, 22 Mar 2025, Samuel Abraham wrote:

> On Sat, Mar 22, 2025 at 3:11 PM Julia Lawall <julia.lawall@inria.fr> wrote:
> >
> >
> >
> > On Sat, 22 Mar 2025, Abraham Samuel Adekunle wrote:
> >
> > > The line is a function call which ends with an opening parenthesis
> > > thereby not adhering to the Linux kernel coding style.
> > >
> > > Modify the function call to include parameters on the same line as
> > > the opening parenthesis to improve readability and consistency while
> > > adhering to Linux coding styles.
> > >
> > > Reported by checkpatch:
> > >
> > > CHECK: Lines should not end with '('
> >
> > Please check the get_maintainer script (see tutorial).  It looks like
> > there are some other people who should receive patches on this driver.
> >
> > julia
> >
> Thank you very much for your review.
>
> Please just to be sure, do I include the emails of the people I
> initially sent the patch to or
> I should only send the patch again to the other people I did not
> include initially?

Send it toeveryone (ald recipients and new ones).  You should write [PATCH
v2] instead of [PATCH].  Below the --- you can write v2: and an
explanation of what has changed, ie adding more recipients.

julia