From: Dan Carpenter <error27@gmail.com>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: disable SDIO function on block size failure
Date: Sat, 1 Aug 2026 00:21:43 +0300 [thread overview]
Message-ID: <am0R56sP8tolOTvC@stanley.mountain> (raw)
In-Reply-To: <20260731161710.44828-1-mhun512@gmail.com>
On Sat, Aug 01, 2026 at 01:17:10AM +0900, Myeonghun Pak wrote:
> sdio_init() enables the SDIO function before configuring the block
> size. If sdio_set_block_size() fails, the function jumps to the release
> path and returns the error without disabling the SDIO function. The
> caller then frees the dvobj directly, so the enabled SDIO function is
> left active on that probe failure path.
>
> Disable the SDIO function before releasing the host when block size
> configuration fails.
>
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> ---
Looks good.
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2026-08-04 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 16:17 [PATCH] staging: rtl8723bs: disable SDIO function on block size failure Myeonghun Pak
2026-07-31 21:21 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am0R56sP8tolOTvC@stanley.mountain \
--to=error27@gmail.com \
--cc=ae878000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mhun512@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox