From: Dan Carpenter <error27@gmail.com>
To: Mohit Mishra <mishraloopmohit@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: sm750fb: Remove legacy kernel-doc comments from header
Date: Thu, 23 Jul 2026 11:25:55 +0300 [thread overview]
Message-ID: <amHQE1sKtB9rxoiA@stanley.mountain> (raw)
In-Reply-To: <20260722175817.213235-1-mishraloopmohit@gmail.com>
On Wed, Jul 22, 2026 at 11:28:16PM +0530, Mohit Mishra wrote:
> The header file sm750_accel.h contains duplicate kernel-doc comments for
> sm750_hw_copyarea and sm750_hw_imageblit. These comments are outdated,
> still reference legacy CamelCase parameters, and generate kernel-doc
> warnings because they do not document the 'accel' parameter.
>
> Since the correct and updated kernel-doc comments are already present
> in the actual implementation file (sm750_accel.c), remove the duplicate
> and outdated comments from the header.
>
> Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
> ---
Acked-by: Dan Carpenter <error27@gmail.com>
Because nothing pisses me off more than comments... :P LOL.
regards,
dan carpenter
prev parent reply other threads:[~2026-07-23 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 17:58 [PATCH 1/2] staging: sm750fb: Remove legacy kernel-doc comments from header Mohit Mishra
2026-07-22 17:58 ` [PATCH 2/2] staging: sm750fb: Clean up whitespace and comment spacing in headers Mohit Mishra
2026-07-23 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amHQE1sKtB9rxoiA@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mishraloopmohit@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox