From: Dan Carpenter <error27@gmail.com>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix XXX placeholder in os_intfs.c comment
Date: Thu, 13 Aug 2026 21:59:22 +0300 [thread overview]
Message-ID: <an4UCgjPjuxfCEuv@stanley.mountain> (raw)
In-Reply-To: <20260813-rtl8723bs-fix-xxx-placeholder-v2-v1-1-a9be805ac0e5@yahoo.pl>
On Thu, Aug 13, 2026 at 07:26:52PM +0200, Tomasz Unger wrote:
> Replace the 'XXX' placeholder with 'securitypriv', the actual
> field name referenced by the commented-out memset() call on the
> following line.
>
> Using the real field name pushes the line past 100 columns, so
> the comment is reflowed to multi-line style in the same change
> to keep it clean. This combines a content fix with a formatting
> change; I considered splitting it into two patches (content
> first, reflow second) but felt the reflow is a direct and
> unavoidable consequence of the content fix rather than an
> unrelated cleanup. Happy to split into two patches if preferred.
Put this kind of meta commentary under the --- cut off line
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
^^^
here.
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index f31196f54b3e..873e00a04bcb 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -664,7 +664,10 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
> /* add for CONFIG_IEEE80211W, none 11w also can use */
> spin_lock_init(&padapter->security_key_mutex);
>
> - /* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
> + /*
> + * We don't need to memset padapter->securitypriv to zero,
> + * because adapter is allocated by vzalloc().
> + */
> /* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */
Just delete the comment and the commented out code.
regards,
dan carpenter
prev parent reply other threads:[~2026-08-13 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260813-rtl8723bs-fix-xxx-placeholder-v2-v1-1-a9be805ac0e5.ref@yahoo.pl>
2026-08-13 17:26 ` [PATCH] staging: rtl8723bs: fix XXX placeholder in os_intfs.c comment Tomasz Unger
2026-08-13 18:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an4UCgjPjuxfCEuv@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox