Linux kernel staging patches
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: remove stale comment and dead code in os_intfs.c
Date: Fri, 14 Aug 2026 10:42:59 +0300	[thread overview]
Message-ID: <an7HA5fniAT6KKjt@stanley.mountain> (raw)
In-Reply-To: <20260814-v2-attempt-final-v2-1-cd3a27834b7f@yahoo.pl>

On Fri, Aug 14, 2026 at 09:26:06AM +0200, Tomasz Unger wrote:
> Remove the comment referencing an unresolved 'XXX' placeholder
> and the commented-out memset() call it describes, rather than
> fixing the placeholder in place.
> 
> Suggested-by: Dan Carpenter <error27@gmail.com>

Normally, we wouldn't give a Suggested-by tag for review comments, but
I won't turn down credit just because it's undeserved.

> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Changes in v2:
> - Removed the stale comment and dead commented-out memset() call, per Dan Carpenter review suggestion.

Thanks!

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter


      reply	other threads:[~2026-08-14  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260814-v2-attempt-final-v2-1-cd3a27834b7f.ref@yahoo.pl>
2026-08-14  7:26 ` [PATCH v2] staging: rtl8723bs: remove stale comment and dead code in os_intfs.c Tomasz Unger
2026-08-14  7:42   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an7HA5fniAT6KKjt@stanley.mountain \
    --to=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=tomasz.unger@yahoo.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox