From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: media: atomisp: remove include/hmm/hmm_common.h file
Date: Wed, 12 Aug 2026 20:22:07 +0300 [thread overview]
Message-ID: <anyrvyBMNMcF6Y8F@archlinux> (raw)
In-Reply-To: <anwnHooR7vBvrNIc@ashevche-desk.local>
On Wed, Aug 12, 2026 at 10:56:14AM +0300, Andy Shevchenko wrote:
> On Thu, Jul 23, 2026 at 09:51:21PM +0300, Nikolay Kulikov wrote:
> > Replace the last used macro with a conditional expression and remove
> > this header file, as it no longer contains any code that is being used.
>
> Split this to two patches: replace (in the similar way how previous patches
> are done) & remove leftovers (file and no more needed includes).
>
> The code wise LGTM, I will give a tag to these patches when they appear in v3
> of the series.
Hi Andy, thanks for the detailed review of this and the other patchs.
I'll fix them and send v3.
Thanks,
Nikolay
prev parent reply other threads:[~2026-08-12 17:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:51 [PATCH v2 0/4] staging: media: atomisp: cleanup pci/hmm/ code Nikolay Kulikov
2026-07-23 18:51 ` [PATCH v2 1/4] staging: media: atomisp: remove unused functions from pci/hmm/ Nikolay Kulikov
2026-08-12 7:49 ` Andy Shevchenko
2026-07-23 18:51 ` [PATCH v2 2/4] staging: media: atomisp: inline macros for checking the bo/bodev pointer Nikolay Kulikov
2026-08-12 7:49 ` Andy Shevchenko
2026-08-12 7:52 ` Andy Shevchenko
2026-07-23 18:51 ` [PATCH v2 3/4] staging: media: atomisp: inline the check_bo_status_*() macros Nikolay Kulikov
2026-08-12 7:51 ` Andy Shevchenko
2026-07-23 18:51 ` [PATCH v2 4/4] staging: media: atomisp: remove include/hmm/hmm_common.h file Nikolay Kulikov
2026-08-12 7:56 ` Andy Shevchenko
2026-08-12 17:22 ` Nikolay Kulikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anyrvyBMNMcF6Y8F@archlinux \
--to=nikolayof23@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox