From: Dan Carpenter <error27@gmail.com>
To: Dhanush Muralidharan <dhanushmuralidharan@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: remove extern from function declarations in header files
Date: Wed, 19 Aug 2026 10:50:23 +0300 [thread overview]
Message-ID: <aoVgP6Cg7NSO_zxR@stanley.mountain> (raw)
In-Reply-To: <20260818152055.486-1-dhanushmuralidharan@gmail.com>
On Tue, Aug 18, 2026 at 08:50:55PM +0530, Dhanush Muralidharan wrote:
> Function declarations in header files are implicitly extern. Remove the redundant extern keyword to clean up the code.
>
> Signed-off-by: Dhanush Muralidharan <dhanushmuralidharan@gmail.com>
> ---
1. Run your patch through checkpatch
2. Add a little note under the --- cut off to say what changed
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
> -extern int rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib);
> +s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib);
3. Don't make unrelated changes like s/int/s32/
4. Also int is better than s32
regards,
dan carpenter
prev parent reply other threads:[~2026-08-19 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 13:16 [PATCH] staging: rtl8723bs: remove extern from function declarations in header files Dhanush Muralidharan
2026-08-18 13:39 ` Dan Carpenter
2026-08-18 15:12 ` Dhanush Muralidharan
2026-08-18 15:20 ` [PATCH v2] " Dhanush Muralidharan
2026-08-19 7:50 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoVgP6Cg7NSO_zxR@stanley.mountain \
--to=error27@gmail.com \
--cc=dhanushmuralidharan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).