From: Dan Carpenter <error27@gmail.com>
To: Tiago Panizio Gottardo <tiago.panizio@hotmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: octeon: fix style issues in ethernet.c
Date: Fri, 21 Aug 2026 09:58:18 +0300 [thread overview]
Message-ID: <aof3Cs95spFEo3Vr@stanley.mountain> (raw)
In-Reply-To: <CPYP284MB085499A0F516D64E9596B9B6FFA32@CPYP284MB0854.BRAP284.PROD.OUTLOOK.COM>
On Fri, Aug 21, 2026 at 01:12:53AM -0300, Tiago Panizio Gottardo wrote:
> Fix several coding style issues in ethernet.c, including line wrapping,
> continuation alignment and function declaration formatting.
>
> No functional changes intended.
>
> Signed-off-by: Tiago Panizio Gottardo <tiago.panizio@hotmail.com>
> ---
1. This patch does a bunch of things at once. Do, one thing per patch.
2. Some of things are weird.
> static void cvm_oct_rx_refill_worker(struct work_struct *work)
> {
> struct octeon_ethernet_platform *plat = container_of(work,
> - struct octeon_ethernet_platform, rx_refill_work.work);
> + struct octeon_ethernet_platform,
> + rx_refill_work.work);
> /*
regards,
dan carpenter
next prev parent reply other threads:[~2026-08-21 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260821041255.1616843-1-tiago.panizio@hotmail.com>
2026-08-21 4:12 ` [PATCH 1/3] staging: octeon: fix style issues in ethernet.c Tiago Panizio Gottardo
2026-08-21 6:58 ` Dan Carpenter [this message]
2026-08-21 13:46 ` Tiago Panizio Gottardo
2026-08-21 4:12 ` [PATCH 2/3] staging: octeon: fix RGMII condition formatting Tiago Panizio Gottardo
2026-08-21 6:59 ` Dan Carpenter
2026-08-21 4:12 ` [PATCH 3/3] staging: octeon: remove unnecessary parentheses Tiago Panizio Gottardo
2026-08-21 14:04 ` [PATCH v2] staging: octeon: fix function declaration formatting Tiago Panizio Gottardo
2026-08-21 14:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aof3Cs95spFEo3Vr@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tiago.panizio@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox