From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6299F30F80C for ; Thu, 27 Aug 2026 19:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787860675; cv=none; b=YOXuJrJJ5MHIMr1OT0n6D21PzZyHWrTCVkfh0A8HoRUoNDZgFMybWUT86FfvsBtLhaqmrTLOhMDetizq8Ah/eSGcfV6GHmaNjDkNUJyXBJmcjskyxoKqoTa2J8J882ryo53cRWR8uoSU0MsZhm4Wfm2tcS+LJPowifGIzjpfEHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787860675; c=relaxed/simple; bh=ajAxoWIobwgQscpuArJ/krQ3ZLgy0OXSTtD4fo/i3Ko=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qO1+RoD1IzDxN5KEk3iY/pLqGu8/iOVtidsWC1ptuZ33hSos8DdM6HpOHQ/MzpbdU2vBwFnSQCmzPeZezE6ZJDBnRLs1esLSMpFN4nTj4WYv3t6EUVl3H16slEnTFgV0B6dkbC+9hGMU35kKtQmyWDtRENf5U+kQM6G7piMsdo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=f8KhKgXw; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="f8KhKgXw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787860675; x=1819396675; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ajAxoWIobwgQscpuArJ/krQ3ZLgy0OXSTtD4fo/i3Ko=; b=f8KhKgXweHqAXAamYW5MrdB2Q6ICtnNF0PSFbo0OEUq8QSwJu3L0JLTu k+c1H6hps3IVy9J/tYFP6DTqKK2NsMI4GTCJES909BNXcjCUUd97DPlU4 /6UPOHtkoXT6QJ+GF/oj4Y2Gt4xhB8ZyS90YO8stCEc7ZsrEV8u3AH9PC UEzdfzJN6VNG4h4ENHLEYZVXMBrdKgunXC1n1AbB4nfnCCjPNcV3wpFQ2 msd7OxXqS1EfwAoMnV2vXHsVo2pcvhlHCfiZNnP/gdGfGo5WxWv6POVfE dpL6JJ6GRV+sL+ssMvBpep187tBnpYyRxivS0/nN888t4BfUFvjZLTmV0 g==; X-CSE-ConnectionGUID: yFEszjFPRBCglbsFF1UvAA== X-CSE-MsgGUID: nOZpbrsTTZa6S1fgZTfEUA== X-IronPort-AV: E=McAfee;i="6800,10657,11888"; a="87503985" X-IronPort-AV: E=Sophos;i="6.25,247,1779174000"; d="scan'208";a="87503985" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2026 12:57:54 -0700 X-CSE-ConnectionGUID: +qBX4yjbQQGU16efcUNBWw== X-CSE-MsgGUID: B2ZQmp6AS4K+fcOn1sb+MA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,247,1779174000"; d="scan'208";a="261825373" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.244.125]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2026 12:57:50 -0700 Date: Thu, 27 Aug 2026 22:57:48 +0300 From: Andy Shevchenko To: Maurizio Casciano Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , Bingbu Cao , Jacopo Mondi , Nicholas Roth , Andy Shevchenko , Hans de Goede , Greg Kroah-Hartman , Jose Maria Martin , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/11] media: atomisp: support the Yoga Book OV2740 link Message-ID: References: <20260826132256.3343451-1-mauriziocasciano7@gmail.com> <20260827181756.2430054-1-mauriziocasciano7@gmail.com> <20260827181756.2430054-9-mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260827181756.2430054-9-mauriziocasciano7@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Aug 27, 2026 at 08:17:53PM +0200, Maurizio Casciano wrote: > The YB1-X91L firmware does not describe the complete camera link. Its > front OV2740 uses two CSI-2 lanes at a 288 MHz link frequency and sends > a 1932x1092 BGGR transport frame with 12 pixels of horizontal and > vertical padding around the 1920x1080 image. > > Allow the AtomISP bridge to provide per-sensor link frequencies and > padding, add the matching OV2740 mode, and derive ISP2401 D-PHY timing > from the sensor link-frequency control. > > The register values are hardware configuration facts checked against > the Lenovo YB1-X91L configuration and physical captures; no proprietary > driver code or tuning binary is included. > > Tested on a Lenovo Yoga Book YB1-X91L with continuous front-camera raw > capture. ... > +bool atomisp_csi2_get_sensor_padding(struct device *dev, > + struct v4l2_area *padding) > +{ > + struct acpi_device *adev; > + > + padding->width = pad_w; > + padding->height = pad_h; > + > + adev = ACPI_COMPANION(dev); > + if (!adev) > + return false; > + padding->width = atomisp_csi2_get_padding_value(adev, > + "CsiPaddingWidth", pad_w); padding->width = atomisp_csi2_get_padding_value(adev, "CsiPaddingWidth", pad_w); > + padding->height = atomisp_csi2_get_padding_value(adev, > + "CsiPaddingHeight", pad_h); In the similar way. > + return padding->width != pad_w || padding->height != pad_h; > +} ... > - ATOMISP_SENSOR_CONFIG("INT33BE", 2, false), /* OV5693 */ > - ATOMISP_SENSOR_CONFIG("INT3477", 4, true), /* OV8858 */ > - ATOMISP_SENSOR_CONFIG("OVTI2740", 2, false), /* OV2740 */ > + ATOMISP_SENSOR_CONFIG("INT33BE", 2, false, 0), /* OV5693 */ > + ATOMISP_SENSOR_CONFIG("INT3477", 4, true, 0), /* OV8858 */ > + /* OV2740 */ > + ATOMISP_SENSOR_CONFIG("OVTI2740", 2, false, 288 * HZ_PER_MHZ), It's better to keep style /* OV5693 */ ATOMISP_SENSOR_CONFIG("INT33BE", 2, false, 0), /* OV8858 */ ATOMISP_SENSOR_CONFIG("INT3477", 4, true, 0), /* OV2740 */ ATOMISP_SENSOR_CONFIG("OVTI2740", 2, false, 288 * HZ_PER_MHZ), Check if that can be done in the previous patch(es) already. -- With Best Regards, Andy Shevchenko