From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D78243BDA4 for ; Sat, 26 Sep 2026 13:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790427603; cv=none; b=AlGtFkq06NFLvrYx8G1Z/QRLCd+xeU5cMP+c7L9snkndWaw9qCnbT6jgrWySz8hSPolPL/yUEmCpU5iUzBdo2wl6EP7gur8z+u7zorlzhjYz4udy2b7qFBs+pvXXcisiMAH5iyMx9G75uM5yKvY3OCXQJXxhVv8jX/BUXy1o6/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790427603; c=relaxed/simple; bh=E3Lfkr3xrImZFSABQNFxau/Yja44Z9Ogq6/F/qSM8WA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FWjO2mKcETtTs0u1+/co9ypl33A/9WrOijuGVgD+W5CqmuwWESb3AvS/fSc1swv2B3LXHSBMxjGOb1iltXySNqR1vjtcijTMwFmSTtjAnPN7d8LlyIZXFxaxLCYxGGcs7su8/C4rIG25DpWZ5JIYVif2xX2pwgJhEA6JzmfVXmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F5XS9/KF; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F5XS9/KF" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49b912d391aso12122515e9.2 for ; Sat, 26 Sep 2026 06:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790427600; x=1791032400; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QVHZ0P3dYyoak6azvRs7KE33EPBoZDYqlIBWuemBV/Y=; b=F5XS9/KF+L5RpbSx622m3geqVuRlY3ZGz7pja+37Smej023KjqGJAHGt6WTn2CspZz VVhcI0vzyDh3ngUxmzwif+sY6GaLcvxDkeRH3V5vYAErUIRpovxGSNkTlOQr+fU52lUI JyodpqGdhRl8eyNuFBARoOrX9jdpWJdB2GtFLlAbadj6UK2rXZsKc4oluKISGsHcxKJW QVVxKz8C34O8q9Xh7VLSmzN5h3JqdCSz2OhTXyZZ4P00Bt0yZKrziZJ3k9nQ5s5wE9Qu 2NSJcrg1jOPmIHH2wdVMF13z/A3yOW2tMnPydye3CkbBhBidiqVbDljEEL5jWEOcm2tQ ZSyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790427600; x=1791032400; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QVHZ0P3dYyoak6azvRs7KE33EPBoZDYqlIBWuemBV/Y=; b=ED0IY8S6MViAy4di/3OqRzEVxEYCGEETmnI9mbQ2BrURHLhescx8kYlJLgbhPPT93p jsKHQSWonig3JKy4uCyS3KMo+yfxt2soqYHsJKWTgJmGNBEZ94rL7Rvva3Bf/HraHGM0 0o7PzbkEvNbf5SM//9H3pNnA7srs0PN+Y7mFF1eQOV4OK9tJ/42zfH/4/j7UqcCq7LO7 //sj48s1WQ915mA7FHERESI+kU3+oo+34IC3ZHEwpCTv3JIAaVDDogDb9IeoWIXKA+mF i9cvB77K2Lf1hfZDpfKOtBwxba2b8sF3HZYMF1uXHE0uJIbjytpMpeDzTtKb42fsLGIT yK6g== X-Forwarded-Encrypted: i=1; AKwUvBw9S0Ak1OdcBPFwMXEHTsG5pZPGV8aLW9ZyT+nW1bzNza5kJnNX83KrBHrcv8QXRsE6pc5CFmczBDnFp6Xn@lists.linux.dev X-Gm-Message-State: AFuF++nX/yQM6x21zI4QNTOX4ssdAJY+mzPAWd2C0gzPjzOFkvlBS4Xf 94zbpYMTa6q8TMuiq4mZ8+rsJTUxNJsC/OuvFHU6crS3ZjIdCR7ZdHBm1w0lJOrIlamaEA== X-Gm-Gg: AYBFou3GDwLvx37MnmPg4N+NuGtzRc0hTr1YgfsiUpiEbmzopJRluNz8D8URaVyDNbK FN96ffDhEMx2KsJjGsh4ldJmeCyP+bUDCkiV5qtyk8PI/MgZ7gpr9OOxOGFuM08HQ5lqXphfpoT JLBW1tOaOmMePmxLUMmdA/b+3E4FSKLKbYziUOw8k5Tr7KaGPqcIGpKBDUl/1TONtl4V7GiaYnw mD77rbpKqJ+j0yEsINslZU6bi+jwDteOxWlhMf7b9J24HZXqsAlx2qyJCup+JYA2Q8E8FAP+St/ NrbuySjzmEdiyWuxqKbySveElVOsGzA3t7loyCNX3jvcaXTMoD2EhdinFUZ9bRbe7reVB7llPhj tKcfqFxdDZcA3QEWqizzYdUulJfUJpyReOwAlNxu8FsISwX77kob3BH1jT7Vpq/h8EZplBeKXR3 V4yziVgtzH1hLFU2pbQpOs8K2hFNyIqt/Dq48xCudY0ltUICgb0Vc3qKfYwhl9tNo0/ho= X-Received: by 2002:a05:600c:1d29:b0:49d:797:83bf with SMTP id 5b1f17b1804b1-49fe66f3c7cmr169660015e9.21.1790427599583; Sat, 26 Sep 2026 05:59:59 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ffd66aa24sm29687885e9.14.2026.09.26.05.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 05:59:59 -0700 (PDT) Date: Sat, 26 Sep 2026 15:59:55 +0300 From: Dan Carpenter To: Artem Shelenko Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: use unsigned int in HAL interface Message-ID: References: <20260926125150.161466-1-Artem.Shelenko@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260926125150.161466-1-Artem.Shelenko@gmail.com> On Sat, Sep 26, 2026 at 03:51:50PM +0300, Artem Shelenko wrote: > The rtl8723bs TODO asks to convert remaining unusual variable types. > > Replace uses of the uint typedef with unsigned int in rtw_hal_init() > and rtw_hal_deinit(), including their local status variables and > declarations. uint is a typedef for unsigned int, so this does not > change behavior. > This sort of patch isn't the correct thing. These functions should be changed to return zero on success and standard negative error codes on failure. It's actually a good thing when bad code looks bad because then there are tools which complain about it and it motivates people to fix it correctly. That's the whole point of static checkers to complain about bad code, so we're working against ourselves by silencing the checkers. regards, dan carpenter