From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Jake Steinman <j@metarealtyinc.ca>
Cc: Ramshouriesh R <rshouriesh@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bingbu Cao <bingbu.cao@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration
Date: Mon, 12 Oct 2026 13:07:52 +0200 [thread overview]
Message-ID: <asy-3JrGjoZCseXU@monoceros> (raw)
In-Reply-To: <b0d32a3b82eca233652f878b7ca91e4dc2d8e863.1791608336.git.j@metarealtyinc.ca>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hello,
On Sat, Oct 10, 2026 at 12:59:21AM -0400, Jake Steinman wrote:
> #include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>
Please don't add new usages of <linux/mod_devicetable.h>. The subsystem
headers provide their respective *_device_id structures already. So
<linux/i2c.h> already provides i2c_device_id (and of_device_id). If you
still think you need a specific header for these structures, please use
<linux/device-id/$subsystem.h>.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-12 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260801-hm1092-driver-v6-0-5979f223748a@gmail.com>
2026-10-10 4:59 ` [PATCH 0/2] media: hm1092: Intel IPU (ACPI) support on top of v6 Jake Steinman
2026-10-10 4:59 ` [PATCH 1/2] media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration Jake Steinman
2026-10-10 9:15 ` Eduard Kulyk
2026-10-12 11:07 ` Uwe Kleine-König [this message]
2026-10-10 4:59 ` [PATCH 2/2] media: staging/ipu7: Add 10-bit greyscale capture formats Jake Steinman
2026-10-12 21:25 ` Sakari Ailus
2026-10-12 23:30 ` Jake Steinman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asy-3JrGjoZCseXU@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=bod@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=j@metarealtyinc.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=rshouriesh@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox