From: Dan Carpenter <error27@gmail.com>
To: Maria Sheikh <mariasheikh812@gmail.com>
Cc: outreachy@lists.linux.dev, vaibhav.sr@gmail.com,
mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager: Add newline to sysfs output
Date: Thu, 29 Oct 2026 21:53:14 +0300 [thread overview]
Message-ID: <auOWGu-Hja90eAmV@stanley.mountain> (raw)
In-Reply-To: <20261029181948.13121-1-mariasheikh812@gmail.com>
On Thu, Oct 29, 2026 at 11:19:40PM +0500, Maria Sheikh wrote:
> Fix checkpatch warning:
>
> WARNING: return sysfs_emit(. . .) formats should include a terminating
> newline.
>
> Add "\n" to the sysfs_emit() format strings of the name, vid, pid,
> intf_id, ip_devices and op_devices attributes.
>
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
This changes how the sysfs file appears to the user and potentially
breaks a script or something. You can't do it without testing.
regards,
dan carpenter
next prev parent reply other threads:[~2026-10-29 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 18:19 [PATCH] staging: greybus: audio_manager: Add newline to sysfs output Maria Sheikh
2026-10-29 18:53 ` Dan Carpenter [this message]
2026-10-29 19:40 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auOWGu-Hja90eAmV@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mariasheikh812@gmail.com \
--cc=mgreer@animalcreek.com \
--cc=outreachy@lists.linux.dev \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox