public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	gregkh@linuxfoundation.org,
	Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	martin@kaiser.cx, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent
Date: Sat, 21 Aug 2021 10:30:27 +0200	[thread overview]
Message-ID: <b0819fe2-e7cf-b6bc-5930-a31e10da811d@gmail.com> (raw)
In-Reply-To: <5110838.kRcMR4ARJC@localhost.localdomain>



On 8/21/21 5:17 AM, Fabio M. De Francesco wrote:
> On Saturday, August 21, 2021 2:05:08 AM CEST Phillip Potter wrote:
>> Remove forward declaration of Efuse_Read1ByteFromFakeContent function
>> from core/rtw_efuse.c, as the function is defined in full directly
>> after this and therefore this forward declaration is redundant.
>>
>> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>> ---
>>   drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------
>>   1 file changed, 6 deletions(-)
> 
> Philip,
> 
> It's pretty clear that this function has only a translation unit visibility.
> Why don't you make it clear by defining it with storage class "static"?
> 
> Thanks,
> 
> Fabio
> 
> 

Hi Phillip,

I agree with Fabio, making the function static avoids the 
[-Wmissing-prototypes] warning and makes it clear that it is only used 
in this file.

Thanks,

Michael

  reply	other threads:[~2021-08-21  8:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21  0:05 [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent Phillip Potter
2021-08-21  3:10 ` kernel test robot
2021-08-21  3:17 ` Fabio M. De Francesco
2021-08-21  8:30   ` Michael Straube [this message]
2021-08-21 10:42     ` Phillip Potter
2021-08-21 14:45 ` Larry Finger
2021-08-21 17:10   ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0819fe2-e7cf-b6bc-5930-a31e10da811d@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox