From: Michael Straube <straube.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: prefer strscpy over strncpy
Date: Wed, 9 Aug 2023 20:02:05 +0200 [thread overview]
Message-ID: <b15bc777-b470-3c15-5ea7-8ef2f89622c3@gmail.com> (raw)
In-Reply-To: <2023080952-maroon-waviness-9621@gregkh>
On 8/9/23 14:21, Greg KH wrote:
> On Sat, Aug 05, 2023 at 09:51:14AM +0200, Michael Straube wrote:
>> Replace strncpy with strscpy in two places where the destination buffer
>> should be NUL-terminated. Found by checkpatch.
>>
>> WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90
>
> If a global search/replace could be done, it would have happend a long
> time ago.
>
> How was this tested? The functions work differently, are you sure there
> is no change in functionality here?
>
It was only compile tested. To me it looked as it does not change
functionality, but looking a bit deeper at it I'm not sure anymore.
So, we should leave it as is.
thank you
Michael
next prev parent reply other threads:[~2023-08-09 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 7:51 [PATCH] staging: rtl8192e: prefer strscpy over strncpy Michael Straube
2023-08-09 12:21 ` Greg KH
2023-08-09 18:02 ` Michael Straube [this message]
2023-08-10 5:01 ` Dan Carpenter
2023-08-25 5:13 ` Michael Straube
2023-09-05 9:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b15bc777-b470-3c15-5ea7-8ef2f89622c3@gmail.com \
--to=straube.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox