From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: make ffaddr2pipehdl() static
Date: Sat, 2 Jul 2022 09:14:31 +0200 [thread overview]
Message-ID: <b3e6cf6e-9185-d9ea-9e2e-15c616e7c76c@gmail.com> (raw)
In-Reply-To: <20220702064626.27506-1-straube.linux@gmail.com>
On 7/2/22 08:46, Michael Straube wrote:
> The function ffaddr2pipehdl() is only used in usb_ops_linux.c.
> Make it static.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/r8188eu/include/usb_ops_linux.h | 2 --
> drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h
> index 641f059ffaf7..966688eedf66 100644
> --- a/drivers/staging/r8188eu/include/usb_ops_linux.h
> +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h
> @@ -26,6 +26,4 @@
> #define usb_read_interrupt_complete(purb, regs) \
> usb_read_interrupt_complete(purb)
>
> -unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr);
> -
> #endif
> diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> index 0269e602b217..220e592b757c 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> @@ -7,7 +7,7 @@
> #include "../include/usb_ops_linux.h"
> #include "../include/rtl8188e_recv.h"
>
> -unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
> +static unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
> {
> unsigned int pipe = 0, ep_num = 0;
> struct usb_device *pusbd = pdvobj->pusbdev;
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
prev parent reply other threads:[~2022-07-02 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 6:46 [PATCH] staging: r8188eu: make ffaddr2pipehdl() static Michael Straube
2022-07-02 7:14 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e6cf6e-9185-d9ea-9e2e-15c616e7c76c@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox