From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B8F3FC2 for ; Thu, 26 Aug 2021 19:12:38 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id q21so7005079ljj.6 for ; Thu, 26 Aug 2021 12:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TvRTLyHaAWmLLRwS1K9bLxp8F5GC7i2/1t+y7IO7tIc=; b=k+Y1nZQYBlSkK/bFtUEhMIaHcLvKdJrcKmmAp3yl9DrjpSVeEUhRK4H7OYUe3D0V5l 992lJOLIPYzY9hUc+qZI1cL8ouu73sxjG23pxM2N4JBX4XNU6am/c7w9P+AevyXpDx8J gcTZHV0u8o0V9Ckyov+I/Nxh3zDDO1dqV5aIDdbOHqadVabxgSbHHF1amDb2FtSEuOwu X8v+Ul4UP8hPt5zg5weICGsNjOWyWid1omp2E/Ko6OtJiVAbBGZWy9CkiDwimX0leOYn uHGpTGxHxcQ+v4H7xN5r00hF0tB5YT3MqyzAqEBp+VGe/3BOS6xnFLEaM2kWSRQqDa3i OSkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TvRTLyHaAWmLLRwS1K9bLxp8F5GC7i2/1t+y7IO7tIc=; b=CAEA0NPioW32ek8gVP8N5a0eS1x6FV3y+PAZrm2PLjql1QNBjqXJW2fnglTHCwH8sx O9cbyaRat9xovNG4+90jcgph9+pmsgtM0W+k8N5v3o8zfza2oHfonZ3/1K7sCDenFnxW 4bja8Qrvs11ySMeh6uL9+MiQ6CGcNydavKTLVBNJ8aiwueYlJtazcPSmcBZgzuwLoBLg cvPvmTDPMOTnnCqn8ajkzaRyNNwi/O7cvfw77x1wpRhsoafTchf8qdA4ePQWrPqxZpnU rRNrHWdBKNPoaXdQRhlI10DShF8NLcwPpAcaPMpc9RPt9royzkGQS/pNqDNx91KXnO23 xanw== X-Gm-Message-State: AOAM532/6Ot5yp9xF68VEYfJN9QwrlZpinrLjoG0gR52KbfYR7E9n64N oiyUQMnzbelGlml9ypPsrYg= X-Google-Smtp-Source: ABdhPJyFuAcZaeVh/2Yqg/K1ya/KDESnAiaINFpi+gsVe+RRig/PlCYYyuCHuoqmozO9smFgQz7/Bg== X-Received: by 2002:a2e:b24f:: with SMTP id n15mr4547207ljm.124.1630005156491; Thu, 26 Aug 2021 12:12:36 -0700 (PDT) Received: from [192.168.1.11] ([46.235.66.127]) by smtp.gmail.com with ESMTPSA id u17sm469454lja.45.2021.08.26.12.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 12:12:36 -0700 (PDT) Subject: Re: [PATCH v3 1/2] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl_vendorreq() To: "Fabio M. De Francesco" , Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Christophe JAILLET References: <20210825035311.8910-1-fmdefrancesco@gmail.com> <20210825035311.8910-2-fmdefrancesco@gmail.com> <1954117.IISOP8hFdM@localhost.localdomain> From: Pavel Skripkin Message-ID: Date: Thu, 26 Aug 2021 22:12:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <1954117.IISOP8hFdM@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/26/21 9:56 PM, Fabio M. De Francesco wrote: > On Thursday, August 26, 2021 8:18:23 PM CEST Pavel Skripkin wrote: >> On 8/25/21 6:53 AM, Fabio M. De Francesco wrote: >> > Replace usb_control_msg() with the new usb_control_msg_recv() and >> > usb_control_msg_send() API of USB Core in usbctrl_vendorreq(). >> > Remove no more needed variables. Move out of an if-else block >> > some code that it is no more dependent on status < 0. Remove >> > redundant code depending on status > 0 or status == len. >> > >> > Suggested-by: Greg Kroah-Hartman >> > Signed-off-by: Fabio M. De Francesco >> > --- >> >> FYI, I've tested this patch with TP-Link TL-WN722N v3 + qemu :) >> >> >> Tested-by: Pavel Skripkin >> >> >> NOTE: I am still not able to apply 2/2, so tested tag is only for 1/2 >> >> >> With regards, >> Pavel Skripkin > > Dear Pavel, > > Thanks for testing. It was very kind from you.I'll add this to the Reviewed-tag > that you had already given to my patch. > > However, I intend to rebase and resend this 1/2 and the 2/2 of this series, because > (as we already found) they logically follow another patch of mine that is still in the > queue ("staging: r8188eu: Remove _enter/_exit_critical_mutex()"). > > The patch above has already been reviewed by Greg and he found that it looks > good, but he cannot apply it because it is not tested (for the reasons I've already > explained with a couple of messages) > > Unfortunately, until "Remove _enter/_exit_critical_mutex()" is not tested, Greg > won't apply it and the 2/2 of this series cannot be applied too. > > Please, if you have time, do you mind to test also that? It would allow me to resend > it with your "Tested-by" tag and Greg will surely apply it. No worries if you have no > time for doing this test, otherwise you may find it at: > > https://lore.kernel.org/lkml/20210819221241.31987-1-fmdefrancesco@gmail.com/ > > Please, if you are interested, read the whole thread. You'll see that Greg would apply > it, only if tested. > > Thanks very much for your help and kindness, > Hi, Fabio! Ok, I will test it until yesterday evening. I want to enable some debug options and sanitizers and recompile the kernel :) Today I will try to automate testing by writing scripts for connect, disconnect and other scenarios. I guess, it will help to test various corner cases Simple test actually passed: I've connected to wifi + pinged google, but mutexes can cause deadlock and other not cool bugs, so I will try to enable as many sanitizers as possible and retest it :) With regards, Pavel Skripkin