Re: [PATCH v11 17/56] media: atomisp: Stop direct calls to queue num_buffers field

Hans de Goede
2023-10-12T12:10:32Z

Hi,

On 10/12/23 13:46, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> CC: Hans de Goede <hdegoede@redhat.com>
> CC: Sakari Ailus <sakari.ailus@linux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
> drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
> index a8a964b2f1a8..09c0091b920f 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
> @@ -1028,7 +1028,7 @@ static int atomisp_qbuf_wrapper(struct file *file, void *fh, struct v4l2_buffer
> struct atomisp_device *isp = video_get_drvdata(vdev);
> struct atomisp_video_pipe *pipe = atomisp_to_video_pipe(vdev);
>
> - if (buf->index >= vdev->queue->num_buffers)
> + if (buf->index >= vb2_get_num_buffers(vdev->queue))
> return -EINVAL;
>
> if (buf->reserved2 & ATOMISP_BUFFER_HAS_PER_FRAME_SETTING) {