From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D53CEAD2; Mon, 30 Dec 2024 08:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735546971; cv=none; b=nC3BwxLFs+WBzxtyj1vHfaJTKCEr/2ofLFIj05EGYG8TamxolS1fIMTKIOEa2SBpXhePvZ3javJRCaDOxMHTxLHFsSvQztryNZ4iv/7AypWpqRnnTv18sx4W8KwmQFTaSd7sCVTt5bbn/benHCcD4Sw91M6Ry0p3blkRb4OHC7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735546971; c=relaxed/simple; bh=iib8E9w1MGsW1BZY46xcGKAWVKaSwK/OAEP04UJUNbY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=lcdKbktEgEpbxTj0slW+T0jjrz+blbcMZRPSa69Np7N2cizNgkzE10cT3qW1kapHyene6pzkcmyLte9OqD/yplROpgJAa+VECexd7E3q25wAyYrrpkTpcfTOq7tj2Dj9iXrdXZqUHR2UqgA4DitFZZIt973bKmaxzlRqBN1SN/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=ag6IOxpK; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="ag6IOxpK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=hKke8sGGINCImp0epVWbfl1Lh5lnzQ6cg5cR2+VSiCI=; t=1735546970; x=1736756570; b=ag6IOxpKG3UksFLNBmoDVVEWWFCWKgQR+HE1ZhnI/skFHYK lLWM2/iC0LF+o/LtduQGcWAI8wGtr40hi+uKSot+DTLDiHauVLszu+ynIVb0XqT4Un2hrwlH0aMRH l4sQ5VtzwVuGyTJLW3DMIqeow++9Sx5ZUEfjNKgjLv1GnpQEBnqBUb9cEg3KI6AoT1qP6uVK3jmzI +IHFailEk6BEcnfd1QhgjLoURYzkvqNUGqSRR7fNer0J2YiGXeHaA3Ut9sZYEClyKnRgJV/bxdpmK kn2Ug01pnCWbHLlZCR6hDYexIv+WV/fqipa447DnwFY89pWY1Z9dhqHUFpy3Nnkg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1tSB2k-0000000FtmF-0Qhn; Mon, 30 Dec 2024 09:22:30 +0100 Message-ID: Subject: Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext From: Johannes Berg To: Philipp Hortmann , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geoff Levand , Simon Horman , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kalle Valo , Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven , Greg Kroah-Hartman , Jeff Johnson , Larry Finger , Nicolas Ferre , Pavel Machek , Stanislaw Gruszka , Gregory Greenman , linuxppc-dev , linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, Arnd Bergmann , Stefan Lippers-Hollmann Date: Mon, 30 Dec 2024 09:22:28 +0100 In-Reply-To: <20241224080755.194508-1-philipp.g.hortmann@gmail.com> References: <20241224080755.194508-1-philipp.g.hortmann@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Tue, 2024-12-24 at 09:07 +0100, Philipp Hortmann wrote: > Driver was contributed in 2008. >=20 > The following reasons lead to the removal: > - This driver generates maintenance workload for itself and for API wext So I've been wondering, why are you so concerned about this? And in particular, more concerned about it than the people actually doing the maintenance? :) We got here because I removed a *staging* driver that was in the way of some wext cleanups, but that had a thousand other reasons to never go anywhere anyway. > - wext is deprecated and only used by two wireless drivers in > mainline kernel true > - no progress changing to mac80211 It fundamentally cannot be converted to mac80211, it has a whole different model. In fact it cannot even be converted to cfg80211 because some APIs it uses just never existed there, and likely never will. > Tested a rebased version of this patch on the Playstation 3. Used > T2 Linux with Kernel 6.12.5 to test the Ethernet connection. >=20 Arguably that's a pretty strong argument for *not* removing it, if it's actually relatively simple today to bring up the latest kernel on a PS3. johannes