From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE4D1272B2 for ; Tue, 16 Apr 2024 10:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713265006; cv=none; b=TdnaYC2dLo6nNSYwAHZDMGxNl8NryQmnRPebgcD6fTpuj4dazVZjUZBZSyRQUIWaMCDweDc7ksI7Y/7bEqJRlvgBg6ikYV5O/f2y5zzoOsUdSMwNYtDQ8qeYOpGJ6hq0MWsVDolLyNfmUxiFse4uejE/qvy0T4yIogkVovDGppU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713265006; c=relaxed/simple; bh=HlgZk8CvLNHX7j9hSVFcL16+f4dTN36eZ1Z1lh6hhAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bm5YHkfv13nX+zs4M2NVh964YZmwUNMRPThMMA/6wN9mauB8Ek3u3QXvN4dq/q7XU0ZcqQHSt2DeSQmeF4u03W53fKeIcRGKljuqW88vXklNjz052JMrRJ7i2xeTw8nmxH+ydhx95/QYXQbMnLYZFiIkrhwHmNhhgRRzISSeJhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R+vZO142; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R+vZO142" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-56e48d0a632so6704793a12.2 for ; Tue, 16 Apr 2024 03:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713265003; x=1713869803; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5+LvTU+20katiBQPmXC4bjjTw0g5f/3WkUMY6Jo3I4w=; b=R+vZO1423FJEEFVtrD3H6YCNlnKYrMOrdkJ1Iynlu8ZtpgX/vEOWBnFPPuyWvg8J0S dimB+aHLxG2qkRD8klWImwSdZxN2LHXSBRlvFALj2FEm1Vu9VFSGcHHJUcUq/bXnmTgu Qu9cItJJM+X4Ez9kDQDcy7ewyQ6Ue/3POZ6BT1xL3bqlpr4lSYP5lKg4I9GtV8See5vE KiMUdXP2SCAwBg7kLsRdoB4x2QxnfvybdsDmLkzbfmLtl+aCEZIZ6VYEK8PNNQpS7cH4 SEMgwHIWpoOvQk+gTPjIJs69myaLujyOa78pmyqFNncB7mY7JFe12CxUu32OSmEG8hjq 3K7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713265003; x=1713869803; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5+LvTU+20katiBQPmXC4bjjTw0g5f/3WkUMY6Jo3I4w=; b=hbRJ+dFpM1V35j83wLvX8pImMbdTows4DQPKRV9defqoH4HICorTRHtGNdFsC/F6Y6 pthP0XHpZC1ErXaZUBzLI7tZFnCIxydlm//3c6V2q0M4i/EqNFDR3oDQdV6qQE24vTCV 5yHTeKy+YHOVN3AZBPH5ALzHD2l2Gvnur8zb1o9gM3mU28UXXOQ3vDB30D0AaDtP7RWf 01KAi9FGDUIQjPTsfCT5cbzBXqjCVU47rxzK/Hb5i7+N79LIw/wdQm0bgN4niR1gL2N5 CjehFxD2NJS4KGCH3XfcBnT5RUEka+R4f7AymNn2x1oIO1rT3axhBUTyAKraZIq+p9E/ W8bA== X-Forwarded-Encrypted: i=1; AJvYcCXFTnqTEZtWP6/rR+kRlQZbBBGq9VmRb6s3dXQ2AAzeY5f008kTwW6VkKSYuhef4wflewkaHx5xa5ouTDWoaJxvLHeqVhNJDac8Ao1pLg== X-Gm-Message-State: AOJu0Yxkg0Gbga4Yn2K4PYZT5VcDAxfUByF3Dpm5ULfNEZeypOQ6A+T9 CtafcELdTu4suymuwUzfaOJ9iJx1/O46wgpP9sciBBmBt0mCQ9u5lYkPGxSuDF8= X-Google-Smtp-Source: AGHT+IFRHzwHYV/k15VsjWZfN2SFFrEwWZL3WX+T78lKXGwI5ZHOHbWBE7IZ649XfmZzZPkChlPXBw== X-Received: by 2002:a50:8d19:0:b0:570:1161:111f with SMTP id s25-20020a508d19000000b005701161111fmr8339541eds.15.1713265003274; Tue, 16 Apr 2024 03:56:43 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id u5-20020aa7d985000000b0057000a2cb5bsm4692942eds.18.2024.04.16.03.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 03:56:42 -0700 (PDT) Date: Tue, 16 Apr 2024 13:56:38 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 23/35] media: dvb-frontends: tda10048: Use the right div Message-ID: References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-23-477afb23728b@chromium.org> <97f51ae8-6672-4bd4-b55b-f02114e3d8d0@moroto.mountain> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 16, 2024 at 12:39:33PM +0200, Ricardo Ribalda wrote: > Hi Dan > > What about going the safe way? > > --- a/drivers/media/dvb-frontends/tda10048.c > +++ b/drivers/media/dvb-frontends/tda10048.c > @@ -341,7 +341,7 @@ static int tda10048_set_wref(struct dvb_frontend > *fe, u32 sample_freq_hz, > /* t *= 2147483648 on 32bit platforms */ > t *= (2048 * 1024); > t *= 1024; > - z = 7 * sample_freq_hz; > + z = (u64)7 * sample_freq_hz; I think your patch works, but it might be nicer without the casts. We end up having the discussion where it's like "Can this hz be above 4GHz?" And, here, I think we're safe but a lot of stuff is pushing up against that limit these days... regards, dan carpenter