From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
saurav.girepunje@hotmail.com, gregkh@linuxfoundation.org,
marcocesati@gmail.com, lee.jones@linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is always false
Date: Mon, 11 Oct 2021 22:41:12 +0530 [thread overview]
Message-ID: <bdc8c280-534d-5de0-050f-2dc3db2e41d0@gmail.com> (raw)
In-Reply-To: <20211011104141.GP2083@kadam>
On 11/10/21 4:11 pm, Dan Carpenter wrote:
> Yep. And please go through the function and clean up all the references
> to max_rf_path. Change the "max_rf_path = 0" to 1 and delete the other
> assignment. Delete the comments about "max_rf_path == 2".
>
> regards,
> dan carpenter
>
Yes, Is it good if I send 2 patches one to remove "if condition which is always
false" and another one to "clean-up all the references to max_rf_path" on a single
patch series.
Regards,
Saurav
prev parent reply other threads:[~2021-10-11 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 7:32 [PATCH] staging: rtl8723bs: hal: remove if condition which is always false Saurav Girepunje
2021-10-10 10:50 ` Fabio Aiuto
2021-10-10 11:02 ` Saurav Girepunje
2021-10-11 10:41 ` Dan Carpenter
2021-10-11 17:11 ` Saurav Girepunje [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdc8c280-534d-5de0-050f-2dc3db2e41d0@gmail.com \
--to=saurav.girepunje@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox