From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA9C143D2 for ; Thu, 23 Jun 2022 04:21:24 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id u12so38411387eja.8 for ; Wed, 22 Jun 2022 21:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UvEF84n19lSXOqhpJPPSQblDfpd6XZf1X0P1snbWIog=; b=Vl9rLwUwaeKipQIahhDvfesL7mLKD5q5lG+qEJ+AyqMb/Xw5nUurD3i3YIkSpsfHF9 Ypp7wduhLoSWdVOuDBEF3w86EKbL650iusZN0MRzJoARloBjmDf7l63cuUCYDebI/DgM 6bQ+eSHEKrXqoiO59CBd0G8idqfUVJvpjOdomBL3X2rKwXFDhVxd7NH42QsOFXAjt3eQ B9mKPH0NufWSXD7/QLoqk2z8vHtLn5g3GTwuADCAqpKTeYg1XJRZWdC71MwrGKJ14JQE EhWzEQS3SzdDkmR4d2Lncqw6Q9t3D9MnWfYAuqq9rakTfgbv0HKvjHANVFAEO7H9Sh5k 79ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UvEF84n19lSXOqhpJPPSQblDfpd6XZf1X0P1snbWIog=; b=M3tAkqWBcz+iAaoOA0CNYTQCIee7RgzjWZTuYRElJ6bDaHThXcs26Qxwc4dwQMFX8r kAFaBbTlE7Ad3XvpT6dfh/KKLSOgNnPTaM5gndXyfWhs5ITbHCQwcf4uXamtLf+1b1Q8 4hTjJearTw/l9AKvHVuoxOPT6yTwunkYnVSZsKvW5ihs3+76hrCHmTvzAtbhadf/d9qF Qav388AXElSiHiui1xN+07S/grRfwZCVG9XSFO5sDdcVoP3kXDhwTguw93/jXDRYSx4Q +13s6JqSRex/4ilB5r4pobfL8tA0WtnN5HKpq2y6sbBEtu6TetjJwsP9T2quHzFW1vCd l4Bg== X-Gm-Message-State: AJIora8YSYbqNFXsuXS58Eoos9LJ/0v1kWIM/zzKqZsW5t1JjLDoU333 r7hFa8PxsxFs2Yvf4MY4rhY= X-Google-Smtp-Source: AGRyM1tcKwNKAopT/HBbeTPOpaKjfT3ou8JklgW1MgoCthPWnzDd8ytOhYyfoiOuT1VAZsPHz51DLw== X-Received: by 2002:a17:906:7292:b0:712:3880:3e7b with SMTP id b18-20020a170906729200b0071238803e7bmr6143374ejl.118.1655958083170; Wed, 22 Jun 2022 21:21:23 -0700 (PDT) Received: from ?IPV6:2003:c7:8f2e:6923:8d97:93cc:4023:b7a9? (p200300c78f2e69238d9793cc4023b7a9.dip0.t-ipconnect.de. [2003:c7:8f2e:6923:8d97:93cc:4023:b7a9]) by smtp.gmail.com with ESMTPSA id w26-20020a50fa9a000000b0043575ae2051sm10806022edr.62.2022.06.22.21.21.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 21:21:22 -0700 (PDT) Message-ID: Date: Thu, 23 Jun 2022 06:21:21 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function Content-Language: en-US To: Chang Yu , Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220623022425.395000-1-marcus.yu.56@gmail.com> From: Philipp Hortmann In-Reply-To: <20220623022425.395000-1-marcus.yu.56@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/23/22 04:24, Chang Yu wrote: > Make rtw_signal_stat_timer_hdl a static function instead of a global > function. > > Signed-off-by: Chang Yu > --- > drivers/staging/r8188eu/core/rtw_recv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c > index cc91638a085d..599d3e55be76 100644 > --- a/drivers/staging/r8188eu/core/rtw_recv.c > +++ b/drivers/staging/r8188eu/core/rtw_recv.c > @@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = { > 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 > }; > > -void rtw_signal_stat_timer_hdl(struct timer_list *t); > +static void rtw_signal_stat_timer_hdl(struct timer_list *t); > > void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv) > { Hi, thanks for your patch. I think you need the "static" for the declaration and the definition of the function. So it is missing in line 1789. Thanks for your support. Bye Philipp