From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: Michael Straube <straube.linux@gmail.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter
Date: Sat, 2 Oct 2021 21:39:20 +0530 [thread overview]
Message-ID: <c00d96ef-0168-c004-7fb1-a422a7c8aaa3@gmail.com> (raw)
In-Reply-To: <59ac1835-2afd-cd7a-d073-5c5d2bb02805@gmail.com>
On 02/10/21 9:08 pm, Michael Straube wrote:
> Thanks for you patch Saurav, just some minor style issue.
>
> On 10/2/21 17:13, Saurav Girepunje wrote:
>> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c
>> b/drivers/staging/r8188eu/core/rtw_efuse.c
>> index 801887f497cf..d33a5b3b4088 100644
>> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
>> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
>> @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>> #define REG_EFUSE_CTRL 0x0030
>> #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse
>> Control. */
>>
>> -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
>> - u16 Offset,
>> +static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
>> u8 *Value)
>
> There is no need for a line break here. ^
>
> Other than that looks good to me.
>
> Thanks,
> Michael
Thanks Michael for review. Yes line break not needed here. I will
update. I will resend the patch.
Regards,
Saurav
next prev parent reply other threads:[~2021-10-02 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 15:13 [PATCH] staging: r8188eu: core: remove unused variable pAdapter Saurav Girepunje
2021-10-02 15:38 ` Michael Straube
2021-10-02 16:09 ` Saurav Girepunje [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-10 18:31 [PATCH] staging: r8188eu: core: remove unused variable padapter Saurav Girepunje
2021-09-10 18:40 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00d96ef-0168-c004-7fb1-a422a7c8aaa3@gmail.com \
--to=saurav.girepunje@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox