From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CF2D3FDE for ; Sat, 2 Oct 2021 16:09:25 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id q23so10721289pfs.9 for ; Sat, 02 Oct 2021 09:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:cc:subject:content-language :to:references:from:in-reply-to:content-transfer-encoding; bh=BMdIVWKp3ys5Ki4OkuinpSXjnqylPnTrfzGBeDzjdeo=; b=Q05CiJuLApqub6sFWeG6+kf66teDw7Z9v7cmgqGKaLhZWKlvjclXChpT+BRNKXJWkC hqIfq7aPINSgCtZGiiR48mO9WNHXkr+5hrIwM5oWYha2Cn0N9+f3h/xNPmASKQcLJ1iZ k/FptNiJLEiXD6k6DlQ5fs5EjCcXtzpNyo9OP1baiLqwS1ZEhYWOADatfp0Gp3Ocw7Wb UaMMtEfVb6o9nmk2ii5h0EM4rqkmR9ePepjYVrORmxlIxNPx1WoEgwidbNpIRgHwsfWi P/aUW+dPFfmOG9+t4Zehvqk+76c6WsohFFGSGeceVN2eht5E2BZqJh83hL24Z0Zo9rkd XAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:cc :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=BMdIVWKp3ys5Ki4OkuinpSXjnqylPnTrfzGBeDzjdeo=; b=SULrho1wzEvXPo0M2idQ1KxF+44+Z56m7S2OoPDDLpJVCA5epOnCtq1dgiFKg+QrFj MqfZGN77I2yXue9pCQB6IrgLVPIhl0RL2q4+RrPGy/UAYFUyC6ARjsJth2+OXAB2XJrl Rr3JvGTMAOVCVU+WxWpdIbnQHEVg2L0VPeVtom/Mq2bTOuAKtb5xGsa7NIzMXuEOllxS 3gwxsW/p2GbvTgODY8KRG1eNoB0o3oAzwr2NDGUNR51udgsEiuCnj+OedgC/mUFcVt5z P3Aku1BSWudRCkJ+7JKKdJYT6hGCLHyDIhQRFhEegXBsg3DSVA54/MgMmLkehvr0ALXA fGmQ== X-Gm-Message-State: AOAM530HnjNWpxKjgmOGZIAY+kuRl1V46TTdpeG+Dzon/CcF2i+/ocHl xgegAOUGWP7SBlg+EmIzIfU= X-Google-Smtp-Source: ABdhPJxYDkCwwhPFpfdW/zRSqjObWrvwbVCUu1j5WXpD1xbbqvw5mWkpoyk/yTGQ8L0Yq3JrKdariQ== X-Received: by 2002:a63:5213:: with SMTP id g19mr3402250pgb.87.1633190964703; Sat, 02 Oct 2021 09:09:24 -0700 (PDT) Received: from [192.168.1.6] ([223.230.105.60]) by smtp.gmail.com with ESMTPSA id b129sm9204377pfg.157.2021.10.02.09.09.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Oct 2021 09:09:24 -0700 (PDT) Message-ID: Date: Sat, 2 Oct 2021 21:39:20 +0530 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Cc: saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter Content-Language: en-US To: Michael Straube , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <59ac1835-2afd-cd7a-d073-5c5d2bb02805@gmail.com> From: Saurav Girepunje In-Reply-To: <59ac1835-2afd-cd7a-d073-5c5d2bb02805@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 02/10/21 9:08 pm, Michael Straube wrote: > Thanks for you patch Saurav, just some minor style issue. > > On 10/2/21 17:13, Saurav Girepunje wrote: >> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent. >> >> Signed-off-by: Saurav Girepunje >> --- >>   drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++---- >>   1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c >> b/drivers/staging/r8188eu/core/rtw_efuse.c >> index 801887f497cf..d33a5b3b4088 100644 >> --- a/drivers/staging/r8188eu/core/rtw_efuse.c >> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c >> @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; >>   #define REG_EFUSE_CTRL        0x0030 >>   #define EFUSE_CTRL            REG_EFUSE_CTRL        /*  E-Fuse >> Control. */ >> >> -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter, >> -                       u16 Offset, >> +static bool Efuse_Read1ByteFromFakeContent(u16 Offset, >>                          u8 *Value) > > There is no need for a line break here.                 ^ > > Other than that looks good to me. > > Thanks, > Michael Thanks Michael for review. Yes line break not needed here. I will update. I will resend the patch. Regards, Saurav