From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3570C22EF0; Mon, 18 Mar 2024 07:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710747564; cv=none; b=puRT2UncY8zKfjk368zpJW9jI07gJAixoos9jn58zXaTrtgNjUg00yntKqqYJFIFUz97Jjn2EY4TDuvbfr5IuBi1G+OujBchHho52BoA2+KcnTTth/FOhWDNSsPcxdK+Zr7uuj2NhH0rapDsbSDN2fv1C3J3niooCFJpbk9xvro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710747564; c=relaxed/simple; bh=EPLKDH3VljXFWrIbZBKT4SRpU0X8LxisU7rbFzf2ES4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=agJQUvI0s++59Mx29KHo2/V88bb8b7/x1FhXEZ89KIrcnLRyGkcF098UtOZxaFyuZKjdAwNNxcxEgny52Cp1LZG0rXTpN9GWlsyvvGdJbhC29dmSkPW2JQa7ffQUV0MzgznNRTnLDuF73aZhyx+aElksFRrTQat3qT0Ohx3XtFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=fdIxhYz0; arc=none smtp.client-ip=192.134.164.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="fdIxhYz0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=MbnpG8HNWfn6gCZ9HY/lgZBQCyKazod2hyic2wq2c0E=; b=fdIxhYz0rTABKuRyQSTg26nnVDVMP0hgoNRMoiEOa3YOnUAa1L/9sWPl vHge/fk4WW//hyx4PJWi0jeeQQXwKUfP/6suV3FncjElHOvgQvyH90Sie HxbfgSjoTLRc/yauUrJ/pJrFZ2W1QRrLcao2V4ccDAY/fEQN6qgsphmPM g=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.07,134,1708383600"; d="scan'208";a="82398387" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2024 08:39:11 +0100 Date: Mon, 18 Mar 2024 08:39:11 +0100 (CET) From: Julia Lawall To: Ayush Tiwari cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Subject: Re: [PATCH 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list In-Reply-To: <10336a70a7d1b87857664e9733a419791e0e2ada.1710703217.git.ayushtiw0110@gmail.com> Message-ID: References: <10336a70a7d1b87857664e9733a419791e0e2ada.1710703217.git.ayushtiw0110@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 18 Mar 2024, Ayush Tiwari wrote: > Rename backupPMKIDList to backup_PMKID_list and remove extra spaces > between RT_PMKID_LIST and backupPMKIDList to address checkpatch > warnings and match the common kernel coding style. > > Signed-off-by: Ayush Tiwari > --- > drivers/staging/rtl8712/mlme_linux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c > index b9f5104f3bf7..a8cda81f4240 100644 > --- a/drivers/staging/rtl8712/mlme_linux.c > +++ b/drivers/staging/rtl8712/mlme_linux.c > @@ -84,7 +84,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter) > netif_carrier_on(adapter->pnetdev); > } > > -static struct RT_PMKID_LIST backupPMKIDList[NUM_PMKID_CACHE]; > +static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE]; This one looks suspicious, because you have changed the definition but no uses. Is it not used? julia > void r8712_os_indicate_disconnect(struct _adapter *adapter) > { > u8 backupPMKIDIndex = 0; > -- > 2.40.1 > > >