From: Pavel Skripkin <paskripkin@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com
Subject: Re: [PATCH -next 0/3] some fix and cleanup for rtl8192e
Date: Wed, 1 Dec 2021 23:15:30 +0300 [thread overview]
Message-ID: <c4855ae4-fb42-ae84-d4b9-3890ae03ef83@gmail.com> (raw)
In-Reply-To: <20211201095036.1763163-1-yangyingliang@huawei.com>
On 12/1/21 12:50, Yang Yingliang wrote:
> patch #1, #2:
> fix error handle case in alloc_rtllib()
>
> patch #3:
> remove unnecessary assignment
>
> Yang Yingliang (3):
> staging: rtl8192e: return error code from rtllib_softmac_init()
> staging: rtl8192e: rtllib_module: fix error handle case in
> alloc_rtllib()
> staging: rtl8192e: rtllib_module: remove unnecessary assignment
>
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_module.c | 17 ++++++++++++-----
> drivers/staging/rtl8192e/rtllib_softmac.c | 6 ++++--
> 3 files changed, 17 insertions(+), 8 deletions(-)
>
Agree with Dan, almost perfect one. Since you are going to send v4,
please add following tag to 1/3 and 2/3 patches because they should be
backported to stable kernels
Fixes: 94a799425eee ("From: wlanfae <wlanfae@realtek.com>")
( Im not kidding, it's real subject line of the patch :) )
With regards,
Pavel Skripkin
prev parent reply other threads:[~2021-12-01 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 9:50 [PATCH -next 0/3] some fix and cleanup for rtl8192e Yang Yingliang
2021-12-01 9:50 ` [PATCH -next 1/3] staging: rtl8192e: return error code from rtllib_softmac_init() Yang Yingliang
2021-12-01 9:50 ` [PATCH -next 2/3] staging: rtl8192e: rtllib_module: fix error handle case in alloc_rtllib() Yang Yingliang
2021-12-01 9:56 ` Dan Carpenter
2021-12-02 2:41 ` Yang Yingliang
2021-12-01 9:50 ` [PATCH -next 3/3] staging: rtl8192e: rtllib_module: remove unnecessary assignment Yang Yingliang
2021-12-01 20:15 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4855ae4-fb42-ae84-d4b9-3890ae03ef83@gmail.com \
--to=paskripkin@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox