From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3C47A for ; Fri, 29 Jul 2022 06:09:11 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id s9so4592021edd.8 for ; Thu, 28 Jul 2022 23:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=F15yzA8MEk1kj7dgO+uysf48NlZcdhWRCvVLxCtDqSw=; b=jCk1tar75x6j04emFxhPlViERasH7LFUp4nze8ZkzuOIhV7BuIQE5JqFeQtcp3Gfat 2cl9sCTtG2RpbbFY8P7QoQqXtiTi/yCYFSWY2H5dqchS8pJ1Dz2et498/h9l24AH3AOZ xxBnewGeJwuDpVwIpIguKAJRlXSmmV4nKRjMyhQEkGNjcVrx1ezUYFuJ08cZmhIAPZg4 ak887o0FdiyBf8hZaS31J0erT2dS78QK5//CIFAHNsK2ebtOse659shZEMcGElKe0BQS ziVOwRvKksYMxUSpQyYXzJJve4w92qOn+27wk3FNbECtMoGYtCaI5Y6jOUSLXfZzN42c ZzSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=F15yzA8MEk1kj7dgO+uysf48NlZcdhWRCvVLxCtDqSw=; b=kASgPw/IO2ZNCHNdWjRFrDGa7jiR+dSL19HFsK1JKivPFId748DCMenUoAne5fBk3d edO9AXDDOzsng5krsu4tsMyo02nvd9fV/BZGk2BwtLokQ0LtED/zSbafR97TvXiLZgjn ogCjH9vYHyoZ+B3p4najeffZwj1S5xuTFVqVwS6pGiFAoeLwqH+bNKvjAwsJQwKu7MPk X+hRWO+NceEI11IyXvnqVD2T5/nAgHbElFj4xWlWvceO7sbQv2BuKdGJY0Yu5GxbjeFc Z6zU0C37tydFqXokYUFSBsdSCo+F7RUWzTl6USVkV0XegfUEpYvLddb/P5LgIdclPsyh hWtw== X-Gm-Message-State: AJIora8+HDGMMVc94zv8Qhsnx0HVzTWna++2XK5rMAMEJfHNVP4XUrZg rKr9N0bHelitGy1reZk6rhE= X-Google-Smtp-Source: AGRyM1sSSl5OUrnyQCEPGznn7Uyt5hmlABmTqUv4WVkkycUAYtiY4vbjGJRZa9EjIkgGFMMdknbiww== X-Received: by 2002:aa7:cc13:0:b0:43d:4c1:3806 with SMTP id q19-20020aa7cc13000000b0043d04c13806mr2031322edt.129.1659074950060; Thu, 28 Jul 2022 23:09:10 -0700 (PDT) Received: from [192.168.1.100] (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id n3-20020aa7db43000000b0043ce5d4d2c3sm1813330edt.14.2022.07.28.23.09.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 23:09:09 -0700 (PDT) Message-ID: Date: Fri, 29 Jul 2022 08:09:08 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/2] staging: r8188eu: more error code cleanups Content-Language: en-US To: Phillip Potter , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, dan.carpenter@oracle.com, paskripkin@gmail.com, martin@kaiser.cx, straube.linux@gmail.com, fmdefrancesco@gmail.com, abdun.nihaal@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220728231150.972-1-phil@philpotter.co.uk> From: Philipp Hortmann In-Reply-To: <20220728231150.972-1-phil@philpotter.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/29/22 01:11, Phillip Potter wrote: > This small series addresses a cleanup suggestion discussed by Greg > Kroah-Hartman and Dan Carpenter, and also includes another function > conversion. It would be a larger series, but my time being what it is, > I intend to chip away at these slowly and steadily. > > Phillip Potter (2): > staging: r8188eu: remove initializer from ret in rtw_pwr_wakeup > staging: r8188eu: convert rtw_set_802_11_add_wep error code semantics > > drivers/staging/r8188eu/core/rtw_ioctl_set.c | 8 ++++---- > drivers/staging/r8188eu/core/rtw_pwrctrl.c | 2 +- > drivers/staging/r8188eu/include/rtw_ioctl_set.h | 2 +- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 5 ++--- > 4 files changed, 8 insertions(+), 9 deletions(-) > Tested-by: Philipp Hortmann # Edimax N150