From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 192082C82 for ; Sat, 29 Jan 2022 16:05:36 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id o64so9437450pjo.2 for ; Sat, 29 Jan 2022 08:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EqfKy3dtUhi7JBYRclICg0WdgZkWY6fzxwHSqCR6ZPI=; b=g19dEYIWrY3UQofi3mTplA5jprQAq+MBqAqRKYo4JfJ0Pdpaob4hQHLtMNBJ6kM98d ySvX1jCJ4XD5D1oxxSMd8FuLCDspE6BmyUVp5A9gWPecI4c3WMndUeUURDBJRE2qSUR3 qmbwuWtJqEjqwDLH7z0QkWYmLTxn1c4D98NfhbJUokuuppYMqKLei1LskmF1ABQ4w0DD +TR6OHDaaD3pu8sBdjdFwxu+uA5YfD0FfFsFFcHX5s4eo0Z9Ih3AO4mprTlQY59GT2gT ahbnDK9QvI4OwQqobAAardMKZywVn6egZzgWdFgRuE5o84s2HrRpFi2XJueV8R2LjZR8 p2Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EqfKy3dtUhi7JBYRclICg0WdgZkWY6fzxwHSqCR6ZPI=; b=3VgKUxKGNKUTxULiUSVT5flPtwNmDlxhIxhpRmIOb9jeN08R4JvtmEPLRjTVNm3gs7 iwaUm+uONqY5pjGu7l3EGv29APAPy/CRv1pl6fNaNxUNnxh8zcQGKSgS02lAviPRpj2C L20QOkeKo8HXAC7BdvPgV7oszbUcEyOnIJ7YxK2pjQcyHXtABhcnvdQ0zOkgRIQfQWvs QZKMCSesSUCB+XtGaAPMq07xEV1DJyQZiZTuyHw1Y30Nl95eth+LcSfuS8k9jSaMYsuo osYgKfyzxINH/4EwY5TTJjHAOxgx/DNrv4bGI/3px2CddgbdGi0QJ4T8OoI3TXDq99we nOVg== X-Gm-Message-State: AOAM532zQ/qTG2+3VyemVQUZIaH9ATJRcYmSHTuyrqznH7gWLdLvq2UZ 1DiZCMtmK3PJo26/5IxxwAI= X-Google-Smtp-Source: ABdhPJzsgvSH+gGJzqQmXJ3UFugV6e/s7qFCPn8U5RFGkwOgTsyIqUUO+V4WiD7cr2Fs+Z4boxHHQQ== X-Received: by 2002:a17:902:7e4a:: with SMTP id a10mr13264848pln.143.1643472335533; Sat, 29 Jan 2022 08:05:35 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id t9sm5672868pjg.44.2022.01.29.08.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:05:34 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 00/23] staging: r8188eu: remove unneeded ret variables Date: Sat, 29 Jan 2022 21:34:06 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patchset does the following to functions in ioctl_linux.c: - Remove unneeded return variable in some functions. These functions cannot be converted to void either because it is an iw_handler function or the function does return error code. - Propagate error code in rtw_p2p_get2 function - Convert some functions that always return 0 to return void v3 -> v4: - Split the changes into smaller patches to make it easier to review - Add a new patch to propagate error code in rtw_p2p_get2 function v2 -> v3: - Remove returns at the end of void functions to conform to coding style v1 -> v2: - As suggested by Greg, change functions that always return 0 and whose return value is not used, to return void instead. - Not removing return variables in rtw_p2p_get2 and rtw_p2p_set as they may need to be used. Abdun Nihaal (23): staging: r8188eu: remove unneeded variable in rtw_wx_get_essid staging: r8188eu: remove unneeded variable in rtw_wx_get_enc staging: r8188eu: remove unneeded variable in rtw_p2p_get staging: r8188eu: remove unneeded variable in rtw_p2p_get_wps_configmethod staging: r8188eu: remove unneeded variable in rtw_p2p_get_go_device_address staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_type staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_name staging: r8188eu: remove unneeded variable in rtw_p2p_get_invitation_procedure staging: r8188eu: propagate error code in rtw_p2p_get2 staging: r8188eu: convert rtw_p2p_set_go_nego_ssid to return void staging: r8188eu: convert rtw_p2p_setDN to return void staging: r8188eu: convert rtw_p2p_get_status to return void staging: r8188eu: convert rtw_p2p_get_req_cm to return void staging: r8188eu: convert rtw_p2p_get_role to return void staging: r8188eu: convert rtw_p2p_get_peer_ifaddr to return void staging: r8188eu: convert rtw_p2p_get_peer_devaddr to return void staging: r8188eu: convert rtw_p2p_get_peer_devaddr_by_invitation to return void staging: r8188eu: convert rtw_p2p_get_groupid to return void staging: r8188eu: convert rtw_p2p_get_op_ch to return void staging: r8188eu: convert rtw_p2p_invite_req to return void staging: r8188eu: convert rtw_p2p_set_persistent to return void staging: r8188eu: convert rtw_p2p_prov_disc to return void staging: r8188eu: convert rtw_p2p_got_wpsinfo to return void drivers/staging/r8188eu/os_dep/ioctl_linux.c | 155 +++++++------------ 1 file changed, 59 insertions(+), 96 deletions(-) -- 2.34.1