From: Deepak R Varma <drv@mailo.com>
To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, paskripkin@gmail.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com,
saurabh.truth@gmail.com
Subject: [PATCH v3 00/10] staging: r8188eu: trivial code cleanup patches
Date: Thu, 20 Oct 2022 13:22:17 +0530 [thread overview]
Message-ID: <cover.1666249715.git.drv@mailo.com> (raw)
Address different kinds of checkpatch complains for the staging/r8188eu module.
The patches are required to be applied in sequence.
Changes in v3:
1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
This was suggested by philipp.g.hortmann@gmail.com
2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com
3. Patch 5 through 10: Included in this version. Additional clean up patches.
Changes in v2:
I incorrectly labeled the first revision as v1 instead of v2. So,
following change recorded under v1 is actually changes for v2. Feedback
provided by philipp.g.hortmann@gmail.com
1. Improve language / grammar for the patch descriptions
2. Further improve code reformatting
Deepak R Varma (10):
staging: r8188eu: use Linux kernel variable naming convention
staging: r8188eu: reformat long computation lines
staging: r8188eu: remove {} for single statement blocks
staging: r8188eu: use htons macro instead of __constant_htons
staging: r8188eu: correct misspelled words in comments
staging: r8188eu: Add space between function & macro parameters
staging: r8188eu: Associate pointer symbol with parameter name
staging: r8188eu: replace leading spaces by tabs
staging: r8188eu: Put '{" on the symbol declaration line
staging: r8188eu: Correct missing or extra space in the statements
drivers/staging/r8188eu/core/rtw_br_ext.c | 122 +++++++++---------
drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 36 +++---
drivers/staging/r8188eu/core/rtw_recv.c | 8 +-
drivers/staging/r8188eu/core/rtw_xmit.c | 14 +-
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +-
drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +-
.../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +-
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 4 +-
.../staging/r8188eu/include/Hal8188EPhyReg.h | 4 +-
.../staging/r8188eu/include/osdep_service.h | 4 +-
.../staging/r8188eu/include/rtl8188e_hal.h | 6 +-
.../staging/r8188eu/include/rtl8188e_spec.h | 18 +--
drivers/staging/r8188eu/include/rtw_cmd.h | 52 ++++----
drivers/staging/r8188eu/include/rtw_io.h | 28 ++--
.../staging/r8188eu/include/rtw_ioctl_set.h | 4 +-
drivers/staging/r8188eu/include/rtw_mlme.h | 22 ++--
.../staging/r8188eu/include/rtw_mlme_ext.h | 12 +-
drivers/staging/r8188eu/include/rtw_recv.h | 4 +-
drivers/staging/r8188eu/include/rtw_xmit.h | 2 +-
drivers/staging/r8188eu/include/wifi.h | 12 +-
drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +-
22 files changed, 181 insertions(+), 185 deletions(-)
--
2.30.2
next reply other threads:[~2022-10-20 7:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 7:52 Deepak R Varma [this message]
2022-10-20 7:52 ` [PATCH v3 01/10] staging: r8188eu: use Linux kernel variable naming convention Deepak R Varma
2022-10-20 15:48 ` Greg KH
2022-10-20 16:28 ` Deepak R Varma
2022-10-20 7:53 ` [PATCH v3 02/10] staging: r8188eu: reformat long computation lines Deepak R Varma
2022-10-20 7:54 ` [PATCH v3 03/10] staging: r8188eu: remove {} for single statement blocks Deepak R Varma
2022-10-20 7:54 ` [PATCH v3 04/10] staging: r8188eu: use htons macro instead of __constant_htons Deepak R Varma
2022-10-20 7:55 ` [PATCH v3 05/10] staging: r8188eu: correct misspelled words in comments Deepak R Varma
2022-10-20 8:22 ` Dan Carpenter
2022-10-20 8:32 ` Deepak R Varma
2022-10-20 9:12 ` Julia Lawall
2022-10-20 9:18 ` Deepak R Varma
2022-10-20 9:24 ` Julia Lawall
2022-10-20 7:56 ` [PATCH v3 06/10] staging: r8188eu: Add space between function & macro parameters Deepak R Varma
2022-10-20 9:17 ` Julia Lawall
2022-10-20 10:02 ` Deepak R Varma
2022-10-20 10:21 ` Julia Lawall
2022-10-20 10:35 ` Deepak R Varma
2022-10-20 20:54 ` Deepak R Varma
2022-10-20 7:57 ` [PATCH v3 07/10] staging: r8188eu: Associate pointer symbol with parameter name Deepak R Varma
2022-10-20 7:58 ` [PATCH v3 08/10] staging: r8188eu: replace leading spaces by tabs Deepak R Varma
2022-10-20 7:59 ` [PATCH v3 09/10] staging: r8188eu: Put '{" on the symbol declaration line Deepak R Varma
2022-10-20 7:59 ` [PATCH v3 10/10] staging: r8188eu: Correct missing or extra space in the statements Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1666249715.git.drv@mailo.com \
--to=drv@mailo.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).