[PATCH v2 0/3] clean up driver code in rtw_ioctl_set

[PATCH v2 0/3] clean up driver code in rtw_ioctl_set

[Emily Peri]

Created patchset to fix all checkpatch warnings in rtw_ioctl_set

Changes since v1:

* Patch 1: "staging: rtl8723bs: remove tab in variable definition"
  * Split previous white space patch into three separate patches
  (feedback from Gregh). Remove tab instead of space (feedback from
  Michael S and Praveen K)

* Patch 2: "staging: rtl8723bs: add newline after variable declaration"
  * Split previous white space patch into three separate patches
  (feedback from Gregh). 

* Patch 3: "staging: rtl8723bs: use tab instead of spaces for indent"
  * Split previous white space patch into three separate patches
  (feedback from Gregh).

* Merged into Greg's tree "rtl8723bs: align block comment stars" 

* Merged into Greg's tree "staging: rtl8723bs: remove unnecessary parenthesis"

Emily Peri (3):
  staging: rtl8723bs: remove tab in variable definition
  staging: rtl8723bs: add newline after variable declaration
  staging: rtl8723bs: use tab instead of spaces for indent

 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH v2 1/3] staging: rtl8723bs: remove tab in variable definition

[Emily Peri]

Remove unnecessary tab in variable definition in rtw_ioctl_set. Issue
found by checkpatch.

Signed-off-by: Emily Peri <eperi1024@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index 8c7daab141db..ede7d2930844 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -367,7 +367,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter)
 
 u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_ssid *pssid, int ssid_max_num)
 {
-	struct	mlme_priv 	*pmlmepriv = &padapter->mlmepriv;
+	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	u8 res = true;
 
 	if (!padapter) {
-- 
2.34.1

[PATCH v2 2/3] staging: rtl8723bs: add newline after variable declaration

[Emily Peri]

Fix checkpatch style warning by adding newline after variable
declaration in rtw_ioctl_set

Signed-off-by: Emily Peri <eperi1024@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index ede7d2930844..47323160e72d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -78,6 +78,7 @@ u8 rtw_do_join(struct adapter *padapter)
 		goto exit;
 	} else {
 		int select_ret;
+
 		spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
 		select_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
 		if (select_ret == _SUCCESS) {
-- 
2.34.1

[PATCH v2 3/3] staging: rtl8723bs: use tab instead of spaces for indent

[Emily Peri]

Replace spaces with tab for indent and correct alignment for closing
brace in rtw_ioctl_set. Issue found by checkpatch.

Signed-off-by: Emily Peri <eperi1024@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index 47323160e72d..3b44f0dd5b0a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -312,7 +312,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
 		if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
 			if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
 				rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have checked whether issue dis-assoc_cmd or not */
-	       }
+		}
 
 		*pold_state = networktype;
 
-- 
2.34.1

Re: [PATCH v2 0/3] clean up driver code in rtw_ioctl_set

[Greg KH]

On Fri, Oct 21, 2022 at 12:54:54PM -0700, Emily Peri wrote:
> Created patchset to fix all checkpatch warnings in rtw_ioctl_set
> 
> Changes since v1:

In the future, please use the proper prefix ("staging: rtl8723bs:" in
this case) for your 0/X emails.

thanks,

greg k-h