linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 00/11] staging: rtl8192e: Remove broken function _rtl92e_if_silent_reset()
Date: Sun, 1 Oct 2023 15:43:48 +0200	[thread overview]
Message-ID: <cover.1696165351.git.philipp.g.hortmann@gmail.com> (raw)

When the function _rtl92e_if_silent_reset() is called the variable
priv->rst_progress is set to RESET_TYPE_SILENT.
Since priv->up is always true the function is left at "if (priv->up) {"
without resetting. Now the function _rtl92e_if_silent_reset() is like
deactivated because the equation at the very beginning is false:
"if (priv->rst_progress == RESET_TYPE_NORESET) {"
This leads to a state where the driver hangs in the reset state and
cannot go forward.
In 30% of the cases the wlan is disconnected and cannot reconnect. The
rest of the time it continues working but no reset is done at all.
Further requests for reset are ignored. Remove broken function that
has never worked.
Some related cleanups are included.

Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
Tested r8192_private_handler with:
	sudo iwpriv wlan0
	sudo iwpriv wlan0 forcereset 1
Tested channel switch.
Transferred this patch over wlan connection of rtl8192e.

Philipp Hortmann (11):
  staging: rtl8192e: Remove ibss_maxjoin_chal
  staging: rtl8192e: Remove dead code from _rtl92e_if_check_reset()
  staging: rtl8192e: Remove RESET_TYPE_NORMAL
  staging: rtl8192e: Remove broken function _rtl92e_if_silent_reset()
  staging: rtl8192e: Remove unused variable rst_progress
  staging: rtl8192e: Remove unused variable reset_in_progress
  staging: rtl8192e: Remove unused parameter from _rtl92e_sta_up()
  staging: rtl8192e: Remove unused parameter from _rtl92e_up()
  staging: rtl8192e: Remove unused variable is_silent_reset
  staging: rtl8192e: Remove unused variables priv->reset_count and
    reset_cnt
  staging: rtl8192e: Remove r8192_private_handler
    _rtl92e_wx_force_reset()

 drivers/staging/rtl8192e/dot11d.c             |   3 -
 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 100 ++++++------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c  | 147 ++----------------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.h  |   5 -
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    |  54 +------
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |  18 +--
 drivers/staging/rtl8192e/rtllib.h             |   2 -
 drivers/staging/rtl8192e/rtllib_softmac.c     |  10 +-
 8 files changed, 66 insertions(+), 273 deletions(-)

-- 
2.42.0


             reply	other threads:[~2023-10-01 13:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 13:43 Philipp Hortmann [this message]
2023-10-01 13:43 ` [PATCH 01/11] staging: rtl8192e: Remove ibss_maxjoin_chal Philipp Hortmann
2023-10-01 13:44 ` [PATCH 02/11] staging: rtl8192e: Remove dead code from _rtl92e_if_check_reset() Philipp Hortmann
2023-10-01 13:44 ` [PATCH 03/11] staging: rtl8192e: Remove RESET_TYPE_NORMAL Philipp Hortmann
2023-10-01 13:44 ` [PATCH 04/11] staging: rtl8192e: Remove broken function _rtl92e_if_silent_reset() Philipp Hortmann
2023-10-01 13:44 ` [PATCH 05/11] staging: rtl8192e: Remove unused variable rst_progress Philipp Hortmann
2023-10-01 13:44 ` [PATCH 06/11] staging: rtl8192e: Remove unused variable reset_in_progress Philipp Hortmann
2023-10-01 13:44 ` [PATCH 07/11] staging: rtl8192e: Remove unused parameter from _rtl92e_sta_up() Philipp Hortmann
2023-10-01 13:45 ` [PATCH 08/11] staging: rtl8192e: Remove unused parameter from _rtl92e_up() Philipp Hortmann
2023-10-01 13:45 ` [PATCH 09/11] staging: rtl8192e: Remove unused variable is_silent_reset Philipp Hortmann
2023-10-01 13:45 ` [PATCH 10/11] staging: rtl8192e: Remove unused variables priv->reset_count and reset_cnt Philipp Hortmann
2023-10-01 13:45 ` [PATCH 11/11] staging: rtl8192e: Remove r8192_private_handler _rtl92e_wx_force_reset() Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1696165351.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).