[PATCH 0/3] staging: greybus: Coding style cleanup patches

linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/3] staging: greybus: Coding style cleanup patches
@ 2023-10-22 10:38 Nandha Kumar Singaram
  2023-10-22 10:39 ` [PATCH 1/3] staging: greybus: Modify lines end with a '(' Nandha Kumar Singaram
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Nandha Kumar Singaram @ 2023-10-22 10:38 UTC (permalink / raw)
  To: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
	greybus-dev, linux-staging, linux-kernel
  Cc: kumaran.4353

This patchset performs code cleanup in greybus driver as per
linux coding style and may be applied in any sequence.

Nandha Kumar Singaram (3):
  staging: greybus: Modify lines end with a '('
  staging: greybus: Alignment should match open parenthesis
  staging: greybus: fixed prefer using ftrace warning

 drivers/staging/greybus/bootrom.c |  2 --
 drivers/staging/greybus/camera.c  | 13 ++++++-------
 2 files changed, 6 insertions(+), 9 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] staging: greybus: Modify lines end with a '('
  2023-10-22 10:38 [PATCH 0/3] staging: greybus: Coding style cleanup patches Nandha Kumar Singaram
@ 2023-10-22 10:39 ` Nandha Kumar Singaram
  2023-10-22 11:18   ` Greg Kroah-Hartman
  2023-10-22 10:40 ` [PATCH 2/3] staging: greybus: Alignment should match open parenthesis Nandha Kumar Singaram
  2023-10-22 10:42 ` [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning Nandha Kumar Singaram
  2 siblings, 1 reply; 8+ messages in thread
From: Nandha Kumar Singaram @ 2023-10-22 10:39 UTC (permalink / raw)
  To: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
	greybus-dev, linux-staging, linux-kernel
  Cc: kumaran.4353

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Lines should not end with a '('

Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
---
 drivers/staging/greybus/camera.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index ae49e37a87e9..feddceddffbb 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(
-		struct gb_camera *gcam,
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
 		struct gb_camera_configure_streams_response *resp,
 		unsigned int nstreams)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] staging: greybus: Modify lines end with a '('
  2023-10-22 10:39 ` [PATCH 1/3] staging: greybus: Modify lines end with a '(' Nandha Kumar Singaram
@ 2023-10-22 11:18   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-22 11:18 UTC (permalink / raw)
  To: Nandha Kumar Singaram
  Cc: Viresh Kumar, Johan Hovold, Alex Elder, greybus-dev,
	linux-staging, linux-kernel, kumaran.4353

On Sun, Oct 22, 2023 at 03:39:28AM -0700, Nandha Kumar Singaram wrote:
> Adhere to linux coding style. Reported by checkpatch.pl:
> CHECK: Lines should not end with a '('
> 
> Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> ---
>  drivers/staging/greybus/camera.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Subject line should be:
	"staging: greybus: camera: Modify..."
right?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/3] staging: greybus: Alignment should match open parenthesis
  2023-10-22 10:38 [PATCH 0/3] staging: greybus: Coding style cleanup patches Nandha Kumar Singaram
  2023-10-22 10:39 ` [PATCH 1/3] staging: greybus: Modify lines end with a '(' Nandha Kumar Singaram
@ 2023-10-22 10:40 ` Nandha Kumar Singaram
  2023-10-22 11:19   ` Greg Kroah-Hartman
  2023-10-22 10:42 ` [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning Nandha Kumar Singaram
  2 siblings, 1 reply; 8+ messages in thread
From: Nandha Kumar Singaram @ 2023-10-22 10:40 UTC (permalink / raw)
  To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
	linux-staging, linux-kernel
  Cc: kumaran.4353

Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
---
 drivers/staging/greybus/camera.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index feddceddffbb..40d3b8aca8f0 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 }
 
 static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp)
+				      struct gb_camera_configure_streams_response *resp)
 {
 	unsigned int max_pkt_size = 0;
 	unsigned int i;
@@ -377,8 +377,8 @@ struct ap_csi_config_request {
 #define GB_CAMERA_CSI_CLK_FREQ_MARGIN		150000000U
 
 static int gb_camera_setup_data_connection(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp,
-		struct gb_camera_csi_params *csi_params)
+					   struct gb_camera_configure_streams_response *resp,
+					   struct gb_camera_csi_params *csi_params)
 {
 	struct ap_csi_config_request csi_cfg;
 	struct gb_connection *conn;
@@ -782,8 +782,8 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len)
 }
 
 static int gb_camera_op_configure_streams(void *priv, unsigned int *nstreams,
-		unsigned int *flags, struct gb_camera_stream *streams,
-		struct gb_camera_csi_params *csi_params)
+					  unsigned int *flags, struct gb_camera_stream *streams,
+					  struct gb_camera_csi_params *csi_params)
 {
 	struct gb_camera *gcam = priv;
 	struct gb_camera_stream_config *gb_streams;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] staging: greybus: Alignment should match open parenthesis
  2023-10-22 10:40 ` [PATCH 2/3] staging: greybus: Alignment should match open parenthesis Nandha Kumar Singaram
@ 2023-10-22 11:19   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-22 11:19 UTC (permalink / raw)
  To: Nandha Kumar Singaram
  Cc: Johan Hovold, Alex Elder, greybus-dev, linux-staging,
	linux-kernel, kumaran.4353

On Sun, Oct 22, 2023 at 03:40:57AM -0700, Nandha Kumar Singaram wrote:
> Adhere to linux coding style. Reported by checkpatch.pl:
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> ---
>  drivers/staging/greybus/camera.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Same subject line problem :(


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning
  2023-10-22 10:38 [PATCH 0/3] staging: greybus: Coding style cleanup patches Nandha Kumar Singaram
  2023-10-22 10:39 ` [PATCH 1/3] staging: greybus: Modify lines end with a '(' Nandha Kumar Singaram
  2023-10-22 10:40 ` [PATCH 2/3] staging: greybus: Alignment should match open parenthesis Nandha Kumar Singaram
@ 2023-10-22 10:42 ` Nandha Kumar Singaram
  2023-10-22 11:19   ` Greg Kroah-Hartman
  2 siblings, 1 reply; 8+ messages in thread
From: Nandha Kumar Singaram @ 2023-10-22 10:42 UTC (permalink / raw)
  To: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
	greybus-dev, linux-staging, linux-kernel
  Cc: kumaran.4353

Adhere to linux coding style. Reported by checkpatch.pl:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
---
 drivers/staging/greybus/bootrom.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
index a8efb86de140..79581457c4af 100644
--- a/drivers/staging/greybus/bootrom.c
+++ b/drivers/staging/greybus/bootrom.c
@@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle)
 {
 	struct gb_bootrom *bootrom = greybus_get_drvdata(bundle);
 
-	dev_dbg(&bundle->dev, "%s\n", __func__);
-
 	gb_connection_disable(bootrom->connection);
 
 	/* Disable timeouts */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning
  2023-10-22 10:42 ` [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning Nandha Kumar Singaram
@ 2023-10-22 11:19   ` Greg Kroah-Hartman
  2023-10-22 12:03     ` Nandha Kumar Singaram
  0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-22 11:19 UTC (permalink / raw)
  To: Nandha Kumar Singaram
  Cc: Viresh Kumar, Johan Hovold, Alex Elder, greybus-dev,
	linux-staging, linux-kernel, kumaran.4353

On Sun, Oct 22, 2023 at 03:42:26AM -0700, Nandha Kumar Singaram wrote:
> Adhere to linux coding style. Reported by checkpatch.pl:
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> ---
>  drivers/staging/greybus/bootrom.c | 2 --
>  1 file changed, 2 deletions(-)

Again, subject line should have "bootrom" in there somewhere, right?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning
  2023-10-22 11:19   ` Greg Kroah-Hartman
@ 2023-10-22 12:03     ` Nandha Kumar Singaram
  0 siblings, 0 replies; 8+ messages in thread
From: Nandha Kumar Singaram @ 2023-10-22 12:03 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Viresh Kumar, Johan Hovold, Alex Elder, greybus-dev,
	linux-staging, linux-kernel, kumaran.4353

On Sun, Oct 22, 2023 at 01:19:33PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Oct 22, 2023 at 03:42:26AM -0700, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> > 
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> > ---
> >  drivers/staging/greybus/bootrom.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Again, subject line should have "bootrom" in there somewhere, right?
> 
> thanks,
> 
> greg k-h

Will update and share the patchset again.

Thanks,
Nandha Kumar

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-10-22 12:03 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-22 10:38 [PATCH 0/3] staging: greybus: Coding style cleanup patches Nandha Kumar Singaram
2023-10-22 10:39 ` [PATCH 1/3] staging: greybus: Modify lines end with a '(' Nandha Kumar Singaram
2023-10-22 11:18   ` Greg Kroah-Hartman
2023-10-22 10:40 ` [PATCH 2/3] staging: greybus: Alignment should match open parenthesis Nandha Kumar Singaram
2023-10-22 11:19   ` Greg Kroah-Hartman
2023-10-22 10:42 ` [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning Nandha Kumar Singaram
2023-10-22 11:19   ` Greg Kroah-Hartman
2023-10-22 12:03     ` Nandha Kumar Singaram

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).