linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Pablo <pablo@pablo.ct.ws>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, hdegoede@redhat.com,
	mchehab@kernel.org, sakari.ailus@linux.intel.com,
	andy@kernel.org, gregkh@linuxfoundation.org
Cc: ~lkcamp/patches@lists.sr.ht, koike@igalia.com, pablolucas890@gmail.com
Subject: Re: [PATCH] staging: media: atomisp: fix coding style
Date: Fri, 4 Jul 2025 11:42:58 +0200	[thread overview]
Message-ID: <d0614e1c-2966-4766-999c-2bc58d643e7e@kernel.org> (raw)
In-Reply-To: <20250503200030.5982-1-pablo@pablo.ct.ws>

On 3-May-25 10:00 PM, Pablo wrote:
> Fix a coding style:
> "ERROR: that open brace { should be on the previous line"
> issue reported in ia_css_vf.host.c:94.
> 
> Signed-off-by: Pablo <pablo@pablo.ct.ws>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  Hey, this is my first patch, I apreciate any feedback, thanks!
>  .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c   | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> index ece5e3da3..0ce75d9bd 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> @@ -91,8 +91,7 @@ configure_kernel(
>  	unsigned int vf_log_ds = 0;
>  
>  	/* First compute value */
> -	if (vf_info)
> -	{
> +	if (vf_info) {
>  		err = sh_css_vf_downscale_log2(out_info, vf_info, &vf_log_ds);
>  		if (err)
>  			return err;


      parent reply	other threads:[~2025-07-04  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03 20:00 [PATCH] staging: media: atomisp: fix coding style Pablo
2025-05-19 13:25 ` Andy Shevchenko
2025-07-04  9:42 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0614e1c-2966-4766-999c-2bc58d643e7e@kernel.org \
    --to=hansg@kernel.org \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=koike@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=pablo@pablo.ct.ws \
    --cc=pablolucas890@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).