Re: [PATCH 2/2] staging: vc04_services: Drop completed TODO item

[Stefan Wahren <wahrenst@gmx.net>]

Hi,

[add the Raspberry Pi guys]

Am 25.10.23 um 12:46 schrieb Laurent Pinchart:
> On Wed, Oct 25, 2023 at 06:33:00AM -0400, Umang Jain wrote:
>> Memory barries and remote_event_*() are documented.
>> Drop the TODO item related to them.
>>
>> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
>> ---
>>   drivers/staging/vc04_services/interface/TODO | 7 -------
>>   1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
>> index 9c79ed549831..2d51f6928e0f 100644
>> --- a/drivers/staging/vc04_services/interface/TODO
>> +++ b/drivers/staging/vc04_services/interface/TODO
>> @@ -33,13 +33,6 @@ such as dev_info, dev_dbg, and friends.
>>   A short top-down description of this driver's architecture (function of
>>   kthreads, userspace, limitations) could be very helpful for reviewers.
>>
>> -* Review and comment memory barriers
>> -
>> -There is a heavy use of memory barriers in this driver, it would be very
>> -beneficial to go over all of them and, if correct, comment on their merits.
>> -Extra points to whomever confidently reviews the remote_event_*() family of
>> -functions.
>> -
from my point of view this part is done.
> Is vchiq so timing sensitive that it can't afford spinlocks ?
Sorry, i cannot answer this question. Maybe Phil or Dave?
>
>>   * Reformat core code with more sane indentations
>>
>>   The code follows the 80 characters limitation yet tends to go 3 or 4 levels of