From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 16/17] staging: rtl8723bs: Remove constant result macro get_iface_type
Date: Sun, 15 Sep 2024 08:38:30 +0200 [thread overview]
Message-ID: <d382321bdd67fdce0ec2357920f67b5dd81ef426.1726339782.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1726339782.git.philipp.g.hortmann@gmail.com>
Remove macro get_iface_type that returns always false to shorten code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 +--
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ----
drivers/staging/rtl8723bs/include/drv_types.h | 1 -
3 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index bbdd5fce28a1..a6383f615686 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -4872,8 +4872,7 @@ void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res)
/* set_link_timer(pmlmeext, DISCONNECT_TO); */
}
- if (get_iface_type(padapter) == IFACE_PORT0)
- rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_CONNECT, 0);
+ rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_CONNECT, 0);
}
/* currently only adhoc mode will go here */
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 6ddd73b9cb29..c60e179bb2e1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -452,10 +452,6 @@ void LPS_Enter(struct adapter *padapter, const char *msg)
if (n_assoc_iface != 1)
return;
- /* Skip lps enter request for adapter not port0 */
- if (get_iface_type(padapter) != IFACE_PORT0)
- return;
-
if (!PS_RDY_CHECK(dvobj->padapters))
return;
diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
index 2b12a2313707..57cbe2876838 100644
--- a/drivers/staging/rtl8723bs/include/drv_types.h
+++ b/drivers/staging/rtl8723bs/include/drv_types.h
@@ -182,7 +182,6 @@ struct registry_priv {
#include <drv_types_sdio.h>
-#define get_iface_type(adapter) (IFACE_PORT0)
#define GET_PRIMARY_ADAPTER(padapter) (((struct adapter *)padapter)->dvobj->if1)
#define GET_IFACE_NUMS(padapter) (((struct adapter *)padapter)->dvobj->iface_nums)
#define GET_ADAPTER(padapter, iface_id) (((struct adapter *)padapter)->dvobj->padapters[iface_id])
--
2.43.0
next prev parent reply other threads:[~2024-09-15 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 6:38 [PATCH 00/17] staging: rtl8723bs: Remove unused functions including read_cam Philipp Hortmann
2024-09-15 6:38 ` [PATCH 01/17] staging: rtl8723bs: Remove unused function dvobj_get_port0_adapter Philipp Hortmann
2024-09-15 6:38 ` [PATCH 02/17] staging: rtl8723bs: Remove unused function rtw_search_max_mac_id Philipp Hortmann
2024-09-15 6:38 ` [PATCH 03/17] staging: rtl8723bs: Remove unused function read_cam Philipp Hortmann
2024-09-15 6:38 ` [PATCH 04/17] staging: rtl8723bs: Remove unused function rtw_get_oper_choffset Philipp Hortmann
2024-09-15 6:38 ` [PATCH 05/17] staging: rtl8723bs: Remove unused function rtw_get_oper_bw Philipp Hortmann
2024-09-15 6:38 ` [PATCH 06/17] staging: rtl8723bs: Remove unused function _ReadCAM Philipp Hortmann
2024-09-15 6:38 ` [PATCH 07/17] staging: rtl8723bs: Remove unused entries from struct hal_ops Philipp Hortmann
2024-09-15 6:38 ` [PATCH 08/17] staging: rtl8723bs: Remove unused function PHY_SetBWMode8723B Philipp Hortmann
2024-09-15 6:38 ` [PATCH 09/17] staging: rtl8723bs: Remove unused function PHY_GetTxPowerLevel8723B Philipp Hortmann
2024-09-15 6:38 ` [PATCH 10/17] staging: rtl8723bs: Remove unused function Hal_BT_EfusePowerSwitch Philipp Hortmann
2024-09-15 6:38 ` [PATCH 11/17] staging: rtl8723bs: Remove unused function rtl8723b_GetHalODMVar Philipp Hortmann
2024-09-15 6:38 ` [PATCH 12/17] staging: rtl8723bs: Remove unused function GetHalODMVar Philipp Hortmann
2024-09-15 6:38 ` [PATCH 13/17] staging: rtl8723bs: Remove unused function rtl8723bs_inirp_init Philipp Hortmann
2024-09-15 6:38 ` [PATCH 14/17] staging: rtl8723bs: Remove unused function rtl8723bs_inirp_deinit Philipp Hortmann
2024-09-15 6:38 ` [PATCH 15/17] staging: rtl8723bs: Remove constant result macro is_primary_adapter Philipp Hortmann
2024-09-15 6:38 ` Philipp Hortmann [this message]
2024-09-15 6:38 ` [PATCH 17/17] staging: rtl8723bs: Remove unused enum with first entry IFACE_PORT0 Philipp Hortmann
2024-09-15 14:44 ` [PATCH 00/17] staging: rtl8723bs: Remove unused functions including read_cam Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d382321bdd67fdce0ec2357920f67b5dd81ef426.1726339782.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox