From: Pavan Bobba <opensource206@gmail.com>
To: Pavan Bobba <pavanbobba206@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Pavan Bobba <opensource206@gmail.com>
Subject: [PATCH
Date: Sun, 8 Oct 2023 07:40:54 +0530 [thread overview]
Message-ID: <d40eb60e6cccf2b5432904abb74bc009fac5e2e1.1696729776.git.opensource206@gmail.com> (raw)
In-Reply-To: <cover.1696729776.git.opensource206@gmail.com>
variable name "byBBVGACurrent" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
drivers/staging/vt6655/baseband.c | 2 +-
drivers/staging/vt6655/channel.c | 6 +++---
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 10 +++++-----
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index a19a75f5d761..7d47b266b87e 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -2146,7 +2146,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data)
by_bb_rx_conf &= 0xDF; /* 1101 1111 */
else
by_bb_rx_conf |= 0x20; /* 0010 0000 */
- priv->byBBVGACurrent = by_data;
+ priv->bbvga_current = by_data;
bb_write_embedded(priv, 0x0A, by_bb_rx_conf); /* CR10 */
}
diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index e20701815db9..6ac7d470c041 100644
--- a/drivers/staging/vt6655/channel.c
+++ b/drivers/staging/vt6655/channel.c
@@ -87,10 +87,10 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
/* Set VGA to max sensitivity */
if (priv->bUpdateBBVGA &&
- priv->byBBVGACurrent != priv->bbvga[0]) {
- priv->byBBVGACurrent = priv->bbvga[0];
+ priv->bbvga_current != priv->bbvga[0]) {
+ priv->bbvga_current = priv->bbvga[0];
- bb_set_vga_gain_offset(priv, priv->byBBVGACurrent);
+ bb_set_vga_gain_offset(priv, priv->bbvga_current);
}
/* clear NAV */
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index b662c74a2dc7..9ae7171d02ee 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -249,7 +249,7 @@ struct vnt_private {
bool bUpdateBBVGA;
unsigned int uBBVGADiffCount;
unsigned char byBBVGANew;
- unsigned char byBBVGACurrent;
+ unsigned char bbvga_current;
unsigned char bbvga[BB_VGA_LEVEL];
long dbm_threshold[BB_VGA_LEVEL];
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 385848df8848..6990129ceb10 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -424,8 +424,8 @@ static void device_init_registers(struct vnt_private *priv)
bb_vt3253_init(priv);
if (priv->bUpdateBBVGA) {
- priv->byBBVGACurrent = priv->bbvga[0];
- priv->byBBVGANew = priv->byBBVGACurrent;
+ priv->bbvga_current = priv->bbvga[0];
+ priv->byBBVGANew = priv->bbvga_current;
bb_set_vga_gain_offset(priv, priv->bbvga[0]);
}
@@ -1058,7 +1058,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
}
}
- if (priv->byBBVGANew == priv->byBBVGACurrent) {
+ if (priv->byBBVGANew == priv->bbvga_current) {
priv->uBBVGADiffCount = 1;
return;
}
@@ -1072,7 +1072,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
dev_dbg(&priv->pcid->dev,
"First RSSI[%d] NewGain[%d] OldGain[%d] Count[%d]\n",
(int)dbm, priv->byBBVGANew,
- priv->byBBVGACurrent,
+ priv->bbvga_current,
(int)priv->uBBVGADiffCount);
}
@@ -1080,7 +1080,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
dev_dbg(&priv->pcid->dev,
"RSSI[%d] NewGain[%d] OldGain[%d] Count[%d]\n",
(int)dbm, priv->byBBVGANew,
- priv->byBBVGACurrent,
+ priv->bbvga_current,
(int)priv->uBBVGADiffCount);
bb_set_vga_gain_offset(priv, priv->byBBVGANew);
--
2.34.1
next prev parent reply other threads:[~2023-10-08 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 2:10 [PATCH Pavan Bobba
2023-10-08 2:10 ` [PATCH Pavan Bobba
2023-10-08 2:10 ` Pavan Bobba [this message]
2023-10-08 2:10 ` [PATCH Pavan Bobba
2023-10-08 2:13 ` [PATCH opensource india
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d40eb60e6cccf2b5432904abb74bc009fac5e2e1.1696729776.git.opensource206@gmail.com \
--to=opensource206@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pavanbobba206@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox