From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E2733D3 for ; Sun, 31 Dec 2023 10:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NdEal02S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704019168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mhBlZj/CgNkT50Cg6dHWCuxupCSZwH7Z6p0s/lyXU80=; b=NdEal02SYon06le7WY8Cc1KsEp+gZSL/qFAmoMOF4Pz8DnxjzEkH+9WsqvfIvXNncT6bHc 1lWdHIEM0Pr4bgrAT6NQUALQdI7Vg8N7WNHOYodTwCTjIR1lYQ+WJgj18N7v6PTBAvNZ/G eJCG9jZqOYK3TtHSwpdVgYbs/Y20bFQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-a3h9cf4cPQWeBFvQVLI79w-1; Sun, 31 Dec 2023 05:39:21 -0500 X-MC-Unique: a3h9cf4cPQWeBFvQVLI79w-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-555f8e831f2so425851a12.1 for ; Sun, 31 Dec 2023 02:39:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704019160; x=1704623960; h=content-transfer-encoding:content-language:cc:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mhBlZj/CgNkT50Cg6dHWCuxupCSZwH7Z6p0s/lyXU80=; b=TQ6AvRsfVlccDLEK9V4M0wZJgAP3U4Y9AIkctEogwPVkadWDLuqVJBla8mLuDowclt oi2bJy7J/ihGinFVqdgXWd1iPcfUHMQS1UlH6vVi8MtG6SABZhysGscqRjcqqfebYe6p kfKRNTRlVlJwzDS+8u6HDStqzc8d1PvOvBRZ4NTCCwNWNLdefNtIdu5/Mj/DzKnHsQMV 83FgI6v2RJs16ofp5BZfJumbjHyNS9nJ3OGaZ6ziMgRuWRZfsEaLYgJ3dlA1ycZWD9rs A6vXFIr7ZlHMbWM5ae3Djbf0qUZoMkaVC708SYhVQ4jD4nK0FHsQ7D5m0qJ6hF03n8mw HlFA== X-Gm-Message-State: AOJu0YxPtoglMenWLUrErLIUH8ra2bimpHm/rb68bPPFDZ0i9H1Ndvym E7m3qxWR1utO/0CepJ4GbxZMuasEouUf3RsOjvZVm7otk1VltZD3WilX4WulfgI7s/8Yddua77Q WPE4UQLCWEPKB9qNA0wkoV1PvCIRtp7onyQ== X-Received: by 2002:a50:8ad7:0:b0:553:2f4a:3f10 with SMTP id k23-20020a508ad7000000b005532f4a3f10mr10720188edk.39.1704019160593; Sun, 31 Dec 2023 02:39:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvh9p5Ew7/8gSa9D2PtLP1k2ZaDstffo0v4th2UWhtr2LWt1X3VGBMKZNuabD9LTIABJkBvQ== X-Received: by 2002:a50:8ad7:0:b0:553:2f4a:3f10 with SMTP id k23-20020a508ad7000000b005532f4a3f10mr10720183edk.39.1704019160299; Sun, 31 Dec 2023 02:39:20 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id p13-20020a05640210cd00b0055298b38768sm13416193edu.80.2023.12.31.02.39.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Dec 2023 02:39:19 -0800 (PST) Message-ID: Date: Sun, 31 Dec 2023 11:39:18 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: [GIT PULL] media: atomisp: Changes for 6.8-1 To: Mauro Carvalho Chehab , Linux Media Mailing List Cc: Sakari Ailus , Andy Shevchenko , linux-staging@lists.linux.dev, Kate Hsuan X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Mauro, Here are the atomisp changes for 6.8. My patches in this set been posted on the list, but only a couple of minutes ago, leaving pretty much zero time for review. Sorry about that, with the holidays the timing did not work out very well. If you don't want to take this pull-request because of this it would be good if you can at least take the patches up to the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h" change. There are only 2 unreviewed patches from me in that set, which fix the atomisp driver not working at all with the latest media_stage/master code. And the rest of the patches in that set are from others and have been reviewed by me. If review finds any significant issues I'll do a set of follow up patches to fix those. Highlights: - The first commit in this pull-request fixes the driver no longer working due to v4l2_subdev_state handling in media_stage/master - Merged a bunch of spelling and other small fixes from various contributors - Gracefully handle missing firmware: - Fix the driver crashing the system when the firmware is missing - Make the driver bind in power-managent-only mode when the firmware is missing so that the ISP is still properly turned off. This requires custom handling, not just standard PCI power-management. This allows the system to properly enter S0i3 with missing ISP firmware, allowing the atomisp driver to be used as a replacement for the pm-only drivers/platform/x86/atomisp/pm.c driver. Regards, Hans The following changes since commit 02d4e62ae2452c83e4a3e279b8e4cb4dcbad4b31: media: i2c: mt9m114: use fsleep() in place of udelay() (2023-12-14 12:40:13 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git tags/media-atomisp-6.8-1 for you to fetch changes up to 1e529948fa3ae6249f1f15dbd77730ea54d0e649: media: atomisp: Update TODO (2023-12-31 11:07:38 +0100) ---------------------------------------------------------------- atomisp staging driver changes for 6.8 Highlights: - The first commit in this pull-request fixes the driver no longer working due to v4l2_subdev_state handling in media_stage/master - Merged a bunch of spelling and other small fixes from various contributors - Gracefully handle missing firmware: - Fix the driver crashing the system when the firmware is missing - Make the driver bind in power-managent-only mode when the firmware is missing so that the ISP is still properly turned off. This requires custom handling, not just standard PCI power-management. This allows the system to properly enter S0i3 with missing ISP firmware, allowing the atomisp driver to be used as a replacement for the pm-only drivers/platform/x86/atomisp/pm.c driver. ---------------------------------------------------------------- Colin Ian King (1): media: atomisp: Remove redundant assignments to variables Dipendra Khadka (13): media: atomisp: Fix spelling mistakes in ia_css_irq.h media: atomisp: Fix a spelling mistake in sh_css_defs.h media: atomisp: Fix repeated "of" in isp2400_input_system_public.h media: atomisp: Fix spelling mistake in isp2400_input_system_global.h media: atomisp: Fix spelling mistakes in circbuf.c media: atomisp: Fix spelling mistake in ia_css_circbuf.h media: atomisp: Fix spelling mistakes in sh_css_mipi.c media: atomisp: Fix spelling mistakes in queue.c media: atomisp: Fix spelling mistakes in rmgr_vbuf.c media: atomisp: Fix spelling mistakes in ia_css_macc_table.host.c media: atomisp: Fix spelling mistakes in ia_css_hdr_types.h media: atomisp: Fix spelling mistake in binary.c media: atomisp: Fix spelling mistake in ia_css_acc_types.h Hans de Goede (15): media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8 media: atomisp: Refactor sensor crop + fmt setting media: atomisp: Remove s_routing subdev call media: atomisp: Remove remaining deferred firmware loading code media: atomisp: Drop is_valid_device() function media: atomisp: Call pcim_enable_device() and pcim_iomap_regions() later media: atomisp: Fix probe error-exit path media: atomisp: Fix atomisp_pci_remove() media: atomisp: Group cpu_latency_qos_add_request() call together with other PM calls media: atomisp: Fix probe()/remove() power-management media: atomisp: Replace atomisp_drvfs attr with using driver.dev_groups attr media: atomisp: Move power-management [un]init into atomisp_pm_[un]init() media: atomisp: Bind and do power-management without firmware media: atomisp: Remove unnecessary msleep(10) from atomisp_mrfld_power() error path media: atomisp: Update TODO Jonathan Bergh (1): media: atomisp: Removed duplicate comment and fixed comment format drivers/staging/media/atomisp/TODO | 10 - drivers/staging/media/atomisp/i2c/gc2235.h | 5 +- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 133 ++++----- .../media/atomisp/pci/atomisp_compat_css20.c | 2 +- drivers/staging/media/atomisp/pci/atomisp_drvfs.c | 148 ++++------ drivers/staging/media/atomisp/pci/atomisp_drvfs.h | 5 +- .../staging/media/atomisp/pci/atomisp_internal.h | 5 +- drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 60 ++-- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 319 +++++++++------------ .../pci/base/circbuf/interface/ia_css_circbuf.h | 2 +- .../media/atomisp/pci/base/circbuf/src/circbuf.c | 6 +- .../staging/media/atomisp/pci/ia_css_acc_types.h | 4 +- drivers/staging/media/atomisp/pci/ia_css_control.h | 29 +- .../staging/media/atomisp/pci/ia_css_firmware.h | 6 +- drivers/staging/media/atomisp/pci/ia_css_irq.h | 6 +- .../atomisp/pci/isp/kernels/hdr/ia_css_hdr_types.h | 4 +- .../kernels/macc/macc_1.0/ia_css_macc_table.host.c | 4 +- .../atomisp/pci/isp2400_input_system_global.h | 2 +- .../atomisp/pci/isp2400_input_system_public.h | 2 +- .../media/atomisp/pci/runtime/binary/src/binary.c | 2 +- .../atomisp/pci/runtime/pipeline/src/pipeline.c | 2 +- .../media/atomisp/pci/runtime/queue/src/queue.c | 22 +- .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 6 +- drivers/staging/media/atomisp/pci/sh_css.c | 33 +-- drivers/staging/media/atomisp/pci/sh_css_defs.h | 2 +- drivers/staging/media/atomisp/pci/sh_css_mipi.c | 4 +- 26 files changed, 344 insertions(+), 479 deletions(-)