From: Khushal Chitturi <khushalchitturi@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: dan.carpenter@linaro.org, straube.linux@gmail.com,
hansg@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case
Date: Fri, 16 Jan 2026 20:49:51 +0530 [thread overview]
Message-ID: <d589ca34-debc-4a4f-811d-fe37802eea7f@gmail.com> (raw)
In-Reply-To: <2026011647-radial-everybody-b544@gregkh>
On 1/16/26 6:43 PM, Greg KH wrote:
> On Fri, Jan 16, 2026 at 11:00:51AM +0530, Khushal Chitturi wrote:
>> Rename several CamelCase identifiers across the driver
>> to follow kernel naming conventions.
>>
>> The following identifiers were renamed:
>> 1) UserPriority to user_priority
>> 2) NumTxOkInPeriod to tx_ok_in_period
>
> Why did you drop the "num"? That has a meaning, right? Now this
> variable looks like a boolean, not a count.
Yes, dropping "num" was a mistake.
I'll replace it with num_tx_ok_in_period in v4.
--
Regards,
Khushal
next prev parent reply other threads:[~2026-01-16 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 5:30 [PATCH v3 0/4] staging: rtl8723bs: coding style and refactoring cleanups Khushal Chitturi
2026-01-16 5:30 ` [PATCH v3 1/4] staging: rtl8723bs: fix operator and type cast spacing Khushal Chitturi
2026-01-16 5:30 ` [PATCH v3 2/4] staging: rtl8723bs: simplify boolean expressions Khushal Chitturi
2026-01-16 13:11 ` Greg KH
2026-01-16 15:11 ` Khushal Chitturi
2026-01-16 5:30 ` [PATCH v3 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case Khushal Chitturi
2026-01-16 13:13 ` Greg KH
2026-01-16 15:19 ` Khushal Chitturi [this message]
2026-01-16 5:30 ` [PATCH v3 4/4] staging: rtl8723bs: fix line length and alignment issues Khushal Chitturi
2026-01-16 13:14 ` Greg KH
2026-01-16 15:23 ` Khushal Chitturi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d589ca34-debc-4a4f-811d-fe37802eea7f@gmail.com \
--to=khushalchitturi@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox