Linux kernel staging patches
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Kathara Sasikumar <katharasasikumar007@gmail.com>
Cc: ~lkcamp/patches@lists.sr.ht, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, helen.koike@collabora.com
Subject: Re: [PATCH] media: atomisp: Fix trailing statement in ia_css_de.host.c
Date: Mon, 2 Sep 2024 12:10:18 +0200	[thread overview]
Message-ID: <d6724490-1f43-4bbd-a80f-575aa31af47f@redhat.com> (raw)
In-Reply-To: <20240730082725.2524-1-katharasasikumar007@gmail.com>

Hi,

On 7/30/24 10:27 AM, Kathara Sasikumar wrote:
> Fix checkpatch diagostic of Error : Trailing statements should be on the
> next line
> 
> Signed-off-by: Kathara Sasikumar <katharasasikumar007@gmail.com>

Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans


> ---
> Hi,  
> 
> This is my first patch for the kernel. 
> Big thanks to Helen Koike for the guidance 
> at her Debconf24 workshop.
> 
> Thank you,
> Kathara
>  .../media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c   | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c
> index 25e3f0822..e66faeda3 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c
> @@ -47,7 +47,8 @@ ia_css_de_dump(
>      const struct sh_css_isp_de_params *de,
>      unsigned int level)
>  {
> -	if (!de) return;
> +	if (!de)
> +		return;
>  	ia_css_debug_dtrace(level, "Demosaic:\n");
>  	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
>  			    "de_pixelnoise", de->pixelnoise);


      reply	other threads:[~2024-09-02 10:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30  8:27 [PATCH] media: atomisp: Fix trailing statement in ia_css_de.host.c Kathara Sasikumar
2024-09-02 10:10 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6724490-1f43-4bbd-a80f-575aa31af47f@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=helen.koike@collabora.com \
    --cc=katharasasikumar007@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox