From: Marc Dietrich <marvin24@gmx.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andrei Coardos <aboutphysycs@gmail.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
linux-tegra@vger.kernel.org, ac100@lists.launchpad.net,
gregkh@linuxfoundation.org, marvin24@gmx.de, alex@shruggie.ro
Subject: Re: [PATCH] staging: nvec: paz00: remove unneeded call to platform_set_drvdata()
Date: Sun, 20 Aug 2023 22:47:54 +0200 (CEST) [thread overview]
Message-ID: <d772f63c-ed2d-ce3a-e466-eb2d2d46f700@gmx.de> (raw)
In-Reply-To: <fb1cc561-926e-478d-a6ce-9d97fa0dd0e1@kadam.mountain>
Hi,
On Thu, 10 Aug 2023, Dan Carpenter wrote:
> On Wed, Aug 09, 2023 at 06:42:11PM +0300, Andrei Coardos wrote:
>> This function call was found to be unnecessary as there is no equivalent
>> platform_get_drvdata() call to access the private data of the driver. Also,
>> the private data is defined in this driver, so there is no risk of it being
>> accessed outside of this driver file.
>>
>> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
>> ---
>
> I think you are right, but why are we doing this? That one line is
> hardly a huge eyesore. It's all risk and no reward.
I guess this was placed in order to implement a module unload function,
but this was never done. The driver also seems to have found another
method to get its private data, so this can be safely removed.
> Have you tested this change on real hardware?
I just checked that it compiles and works on my AC100.
Thanks!
Marc
next prev parent reply other threads:[~2023-08-20 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:42 [PATCH] staging: nvec: paz00: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-10 4:59 ` Dan Carpenter
2023-08-20 20:47 ` Marc Dietrich [this message]
2023-10-10 16:13 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d772f63c-ed2d-ce3a-e466-eb2d2d46f700@gmx.de \
--to=marvin24@gmx.de \
--cc=aboutphysycs@gmail.com \
--cc=ac100@lists.launchpad.net \
--cc=alex@shruggie.ro \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox