Re: [PATCH] staging: nvec: paz00: remove unneeded call to platform_set_drvdata()

Marc Dietrich
2023-08-20T20:48:00Z

Hi,

On Thu, 10 Aug 2023, Dan Carpenter wrote:

> On Wed, Aug 09, 2023 at 06:42:11PM +0300, Andrei Coardos wrote:
>> This function call was found to be unnecessary as there is no equivalent
>> platform_get_drvdata() call to access the private data of the driver. Also,
>> the private data is defined in this driver, so there is no risk of it being
>> accessed outside of this driver file.
>>
>> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
>> ---
>
> I think you are right, but why are we doing this? That one line is
> hardly a huge eyesore. It's all risk and no reward.

I guess this was placed in order to implement a module unload function,
but this was never done. The driver also seems to have found another
method to get its private data, so this can be safely removed.

> Have you tested this change on real hardware?

I just checked that it compiles and works on my AC100.

Thanks!

Marc