From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: do not spam the kernel log
Date: Mon, 8 Aug 2022 23:40:52 +0200 [thread overview]
Message-ID: <db7b4ace-d8e7-a8c9-12c8-66049043ea32@gmail.com> (raw)
In-Reply-To: <20220808065023.3175-1-straube.linux@gmail.com>
On 8/8/22 08:50, Michael Straube wrote:
> Drivers should not spam the kernel log if they work properly. Convert
> the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use
> netdev_dbg() instead of pr_info() so that developers can still enable
> it if they want to see this information.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 ++-
> drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> index 5b8f1a912bbb..58a193334b91 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> @@ -688,6 +688,7 @@ Hal_EfuseParseIDCode88E(
> )
> {
> struct eeprom_priv *pEEPROM = &padapter->eeprompriv;
> + struct net_device *netdev = padapter->pnetdev;
> u16 EEPROMId;
>
> /* Check 0x8129 again for making sure autoload status!! */
> @@ -699,7 +700,7 @@ Hal_EfuseParseIDCode88E(
> pEEPROM->bautoload_fail_flag = false;
> }
>
> - pr_info("EEPROM ID = 0x%04x\n", EEPROMId);
> + netdev_dbg(netdev, "EEPROM ID = 0x%04x\n", EEPROMId);
> }
>
> static void Hal_ReadPowerValueFromPROM_8188E(struct txpowerinfo24g *pwrInfo24G, u8 *PROMContent, bool AutoLoadFail)
> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
> index cac9553666e6..22e91657f3fb 100644
> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c
> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
> @@ -635,7 +635,7 @@ int _netdev_open(struct net_device *pnetdev)
> if (status == _FAIL)
> goto netdev_open_error;
>
> - pr_info("MAC Address = %pM\n", pnetdev->dev_addr);
> + netdev_dbg(pnetdev, "MAC Address = %pM\n", pnetdev->dev_addr);
>
> status = rtw_start_drv_threads(padapter);
> if (status == _FAIL) {
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
prev parent reply other threads:[~2022-08-08 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 6:50 [PATCH] staging: r8188eu: do not spam the kernel log Michael Straube
2022-08-08 21:40 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db7b4ace-d8e7-a8c9-12c8-66049043ea32@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox