From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F8791553BC for ; Wed, 28 Aug 2024 10:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724839356; cv=pass; b=sqTscA/OCwHG4O1ySd6davJqxnHy89B3Yky4a/mPmWtFkzB9or+1MNQV4HRytozxj0OHoUltKaz/kwISvoQ3DWCxHuECjmcZoacC+SnNIdYRjR2+nngpq7YrUTHwiKrTDAJzxqsDbRA60sGkR1a3DX9lltiolgFhgK4VuBs7D2I= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724839356; c=relaxed/simple; bh=cVhdnGh1gtNtWJrnF9ZbO5IS+WmF+xa16YhB9Qx5chE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=US6V8N9+Lha6bBZIdYm/CZuksFSR9Q1WzxC31GmEG1Zw3eXEflZlTNNXc54gM2nWNNfsAXWMZAs8x/7iScfKXCRlKWGujznhKGb9SBm8pSnJI0u0SwE0/I3AO/TehtYrN419IJwRPWWG1YxOPSU/RzRitE+an5PlpFdKHx8cR2s= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=julien.massot@collabora.com header.b=cSjo8wbN; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=julien.massot@collabora.com header.b="cSjo8wbN" ARC-Seal: i=1; a=rsa-sha256; t=1724839350; cv=none; d=zohomail.com; s=zohoarc; b=P9ItgZk4OFmZ3oZujLJajth3nyKBxbqHHC7XSxBB/YDUGnVX1kxeJYvObWVpPwFOl7HxitnIIkdVE+1oWZu6e2WY2XPr7u68vpBCqzVfRPj30FziypcdVsNxNojoSQtNQMxmw2TkZ/6BIz0xiD97DZ2Ge90KVbc/M8ZD9h0myRU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1724839350; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZLM7oCag8bEqv46GHSaKZQveF6nYFv5zvA0CwiARDdg=; b=OMkxr3BYhuhmPXPMZ2GR8bgkjSU4bPZ/ZbqUVOMrwxD6LqIt5wekHRG05wEQJX5Q5PRel7pIe57K1RpZaE3jsjFUouqwPfdvujDriK4u0UFggRvVlIRwvVXFyFBfga/utegYOCdIHjcVyN6G3lhD0w1Wb3aPrmVRT6xQQXXIuaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=julien.massot@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1724839350; s=zohomail; d=collabora.com; i=julien.massot@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ZLM7oCag8bEqv46GHSaKZQveF6nYFv5zvA0CwiARDdg=; b=cSjo8wbNH9XtnKMCb0bvgScrc5QDlcDTq3YTb3q7YMKaSVNpruDNaCusCG/xxjRg PQN4466OjR/6rysuinfmNwDJEEswNbWHaaxEBaMOdTbMU6AtgeFMwD0jCSPeFFoB8oI G2X4mazr3FQ6+LpepwETeezxK/gpO6q77uSJ7AB0= Received: by mx.zohomail.com with SMTPS id 1724839349104444.9895094581451; Wed, 28 Aug 2024 03:02:29 -0700 (PDT) Message-ID: Date: Wed, 28 Aug 2024 12:02:24 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] media: staging: max96712: Add support for MAX96724 To: Tommaso Merciai , =?UTF-8?Q?Niklas_S=C3=B6derlund?= Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev, linux-renesas-soc@vger.kernel.org References: <20240827131841.629920-1-niklas.soderlund+renesas@ragnatech.se> <20240827131841.629920-3-niklas.soderlund+renesas@ragnatech.se> Content-Language: en-US From: Julien Massot In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Hi Tommaso, On 8/27/24 3:55 PM, Tommaso Merciai wrote: > Hi Niklas, > Thanks for your work. > > Hi Julien, > I think we can adopt a similar approach for the max96716 deserializer using your work > on max96714 driver. What do you think? > > Thanks in advance. I don't think that supporting MAX96716 and MAX96714 in the same driver is the best option MAX96714 is a very simple device with one input one output one video pipe. While the MAX96716 is a two inputs/outputs with four different pipes. IMHO we should have one driver for the 1 port GMSL2 devices, another driver for the dual deserializers which will introduce more complex routing, and another one for the quad deserializers since the register layout is too much different. But that's only my opinion let's see when we will implement the dual deserializer support. We can of course share some functions for those drivers like GPIO handling or pattern generation. Regards, Julien